doc: use arch agnostic clang path in fuzzing doc (macOS) #27056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
jonatack
reviewed
Feb 7, 2023
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
Concept ACK, as it looks like the path changed from /usr/local/opt/ for x86_64 to /opt/homebrew/opt/ for ARM64.
Member
|
ACK 8b16f7b |
jonatack
reviewed
Feb 7, 2023
fanquake
force-pushed
the
macos_fuzzing_doc_arch_agnostic
branch
from
8b16f7b to
b49e19c
Compare
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 8, 2023
… (macOS) b49e19c doc: use arch agnostic clang path in fuzzing doc (macOS) (fanquake) Pull request description: The current path will only work for clang installed via brew on x86_64 macOS. ACKs for top commit: hebasto: ACK b49e19c, similar to 7028365. Tree-SHA512: 8ae4845e1953d5a7178f2b422e2241af1057d8cce1ab79da65df0cd068456dbf85da3489355f81fc4ee09ba602a4b53e989e2dc02476b4abf6c5b3bc3e96473b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current path will only work for clang installed via brew on x86_64 macOS.