depends: define __BSD_VISIBLE for FreeBSD bdb build
#26994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for additional definitions (IPC_R & friends), to be available, when compiling under C11. See: maflcko/bitcoin-core-nightly#4.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
maflcko
reviewed
Feb 8, 2023
| $(package)_config_opts_android=--with-pic | ||
| $(package)_cflags+=-Wno-error=implicit-function-declaration -Wno-error=format-security | ||
| $(package)_cppflags_freebsd=-D_XOPEN_SOURCE=600 | ||
| $(package)_cppflags_freebsd=-D_XOPEN_SOURCE=600 -D__BSD_VISIBLE=1 |
Member
There was a problem hiding this comment.
Maybe document that this can be removed along with the bdb removal?
Member
Author
There was a problem hiding this comment.
I think we'll delete this file entirely if/when bdb is removed, so probably self-documenting?
Member
There was a problem hiding this comment.
Maybe document that this can be removed along with the bdb removal?
It seems inevitable as file name is bdb.mk :)
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 8, 2023
…build 0e02f72 depends: define `__BSD_VISIBLE` for FreeBSD bdb build (fanquake) Pull request description: Required for additional definitions (`IPC_R` & friends), to be available, when compiling under C11, which would otherwise cause compile fails. See: maflcko/bitcoin-core-nightly#4. ACKs for top commit: hebasto: ACK 0e02f72, tested on FreeBSD 13.1: Tree-SHA512: 885d4aa341d9668da360cf6dfafb97ce816803c54e76c0a06e448db39a723666d42cd14b3e713d17ecbe33163f5af69924567cf449d679a2db95b36357005d43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for additional definitions (
IPC_R& friends), to be available, when compiling under C11, which would otherwise cause compile fails.See: maflcko/bitcoin-core-nightly#4.