-
Notifications
You must be signed in to change notification settings - Fork 54
docs: overhaul all #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: overhaul all #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ace m8.
Left a few comments inline. Thanks for taking on this tank-less task!
docs/logging_monitoring.md
Outdated
``` | ||
|
||
The data can be retrieved from the Prometheus exporter on port `9332`, example: | ||
The data can be retrieved firectly from the Prometheus exporter container in the tank pod via port `9332`, example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*directly
`uv` can also run tools (like `ruff`) without external installation, simply run `uvx ruff check .` or `uvx ruff format .` to use a uv-managed format/lint on the project. | ||
|
||
## Release process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is better in a dedicated document? It's not really developer notes or even relevant for general contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only if you insist. i prefer having all the meta stuff in one place whether its for new contributors or us old salts.
docs/logging_monitoring.md
Outdated
|
||
Example: | ||
|
||
```sh | ||
$ warnet bitcoin debug-log 0 | ||
$ warnet bitcoin debug-log tank=0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tank-0000
docs/warnet.md
Outdated
and additionally include 7 extra random outbounds per node. Include lightning | ||
channels and their policies as well. | ||
Returns XML file as string with or without --outfile option. | ||
and additionally include 7 extra random outbounds per node. Include lightning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did apidocs.py add this weird whitespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suppose it did, im just going to remove the entire command since its not implemented anyway
addressed some comments |
e9bb274
to
7c2a899
Compare
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
7c2a899
to
ca35234
Compare
rebased on main after #588 |
More updates since the helm refactor. Removed a few references to
rpc-0
or "the server", removed irrelevant files like lightning. Combined all developer notes into one file. Rebuilt cli API docs. Major changes to logging infrastructure. Only functional change is removing the default path for snapshot export.