Skip to content

Conversation

pinheadmz
Copy link
Contributor

More updates since the helm refactor. Removed a few references to rpc-0 or "the server", removed irrelevant files like lightning. Combined all developer notes into one file. Rebuilt cli API docs. Major changes to logging infrastructure. Only functional change is removing the default path for snapshot export.

Copy link
Contributor

@willcl-ark willcl-ark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ace m8.

Left a few comments inline. Thanks for taking on this tank-less task!

```

The data can be retrieved from the Prometheus exporter on port `9332`, example:
The data can be retrieved firectly from the Prometheus exporter container in the tank pod via port `9332`, example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*directly

`uv` can also run tools (like `ruff`) without external installation, simply run `uvx ruff check .` or `uvx ruff format .` to use a uv-managed format/lint on the project.

## Release process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is better in a dedicated document? It's not really developer notes or even relevant for general contributors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only if you insist. i prefer having all the meta stuff in one place whether its for new contributors or us old salts.


Example:

```sh
$ warnet bitcoin debug-log 0
$ warnet bitcoin debug-log tank=0000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tank-0000

docs/warnet.md Outdated
and additionally include 7 extra random outbounds per node. Include lightning
channels and their policies as well.
Returns XML file as string with or without --outfile option.
and additionally include 7 extra random outbounds per node. Include lightning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did apidocs.py add this weird whitespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suppose it did, im just going to remove the entire command since its not implemented anyway

@pinheadmz
Copy link
Contributor Author

addressed some comments

@bdp-DrahtBot
Copy link
Collaborator

bdp-DrahtBot commented Sep 11, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@pinheadmz
Copy link
Contributor Author

rebased on main after #588

@josibake josibake merged commit f8a6c04 into bitcoin-dev-project:main Sep 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants