Refactor hardcoded strings into a config / constants file #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice clean up! LGTM, I'd call that file |
also remove create cmd, we only need init and create will be used for creating networks
josibake
force-pushed
the
refactor-config
branch
from
90b2280 to
96d9eee
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Closes #510 |
Closed
|
ACK |
|
I’m happy to rebase others on this |
shall we merge it? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got a lot of hardcoded stuff in each file, this moves it all into one place. This is strictly a refactor, but left some todos that I can tackle in a follow up PR, namely the logging stuff should be using a helm chart.
There's also a few opportunities to dry things up a bit, but I'll tackle that in a followup and leave this one just to moving hardcoded stuff around.