Stop treating ECDH as experimental #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK, I think it's well tested and the API is sufficiently generic that I don't expect it needing changes any time soon. |
Contributor
|
Nice, ACK. |
Contributor
|
ACK 5a81a2a |
jonasnick
force-pushed
the
ecdh-stable
branch
from
5a81a2a to
2254932
Compare
Contributor
Author
|
rebased |
Contributor
Author
and schnorrsig :) |
elichai
reviewed
Sep 12, 2020
Contributor
|
ACK 14392d6 |
real-or-random
approved these changes
Sep 13, 2020
Contributor
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
ACK 14392d6 code review, did not test
Contributor
|
utACK 14392d6, but needs rebase |
jonasnick
force-pushed
the
ecdh-stable
branch
from
14392d6 to
e6e3d5d
Compare
Contributor
Author
|
rebased |
elichai
approved these changes
Oct 21, 2020
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 22, 2020
Summary: Backport of secp256k1 [[bitcoin-core/secp256k1#809 | PR809]]. Depends on D8044. Test Plan: ./autogen.sh mkdir build && cd build ../configure --enable-module-ecdh=yes make check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8049
deadalnix
pushed a commit
to Bitcoin-ABC/secp256k1
that referenced
this pull request
Oct 23, 2020
Summary: Backport of secp256k1 [[bitcoin-core/secp256k1#809 | PR809]]. Depends on D8044. Test Plan: ./autogen.sh mkdir build && cd build ../configure --enable-module-ecdh=yes make check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #665