Switch x86_64 asm to use "i" instead of "n" for immediate values. #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constraint "n" is a more obscure setting which is needed for special cases that don't apply to our use. Use of "n" exposed some bugs in pre-release versions of clang. This fixes #594
Contributor
Author
|
I know the issue has been closed, but since this was reported multiple times independently (in bitcoin repo too) we're likely to see more of it. |
Contributor
|
utACK d58bc93 |
Contributor
|
utACK d58bc93 |
gmaxwell
added a commit
that referenced
this pull request
Mar 11, 2019
… values. d58bc93 Switch x86_64 asm to use "i" instead of "n" for immediate values. (Gregory Maxwell) Pull request description: The constraint "n" is a more obscure setting which is needed for special cases that don't apply to our use. Use of "n" exposed some bugs in pre-release versions of clang. This fixes #594 Tree-SHA512: 1ffba02aa6bfcd0b6f731196e5d007f4ddb0f03f53b30a2633f0e376578cf7f828570579502f2de721dcda8034fd8e7bea822542bf36032d98ef802b4cf27725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constraint "n" is a more obscure setting which is needed for
special cases that don't apply to our use.
Use of "n" exposed some bugs in pre-release versions of clang.
This fixes #594