Skip to content

Conversation

@MarnixCroes
Copy link
Contributor

if desired, can also update ORG_NAME to Bitcoin Core

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@laanwj
Copy link
Member

laanwj commented Apr 24, 2024

if desired, can also update ORG_NAME to Bitcoin Core

The reason that this was never done is because it changes where the Qt settings files are stored. For example this is ~/.config/<ORG_NAME>/<APP_NAME> on Linux.

i'm not sure what actually is the effect of changing the domain, but this shouldn't be done without checking what it is used for.

@hebasto
Copy link
Member

hebasto commented Apr 24, 2024

if desired, can also update ORG_NAME to Bitcoin Core

Are there any issues with the current code? If not, then this PR lacks motivation.

@MarnixCroes
Copy link
Contributor Author

ok, it came across in the qt-qml repo, I looked here and assumed it was forgotten to be updated.
nvm

@MarnixCroes MarnixCroes deleted the ORG_DOMAIN branch April 25, 2024 00:04
@laanwj
Copy link
Member

laanwj commented Apr 25, 2024

Right. i think qt-qml does something substantially different with regard to settings, so it may be warranted there.

@bitcoin-core bitcoin-core locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants