Skip to content

Remove progress bar on modal overlay #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2021
Merged

Remove progress bar on modal overlay #300

merged 1 commit into from
Apr 30, 2021

Conversation

@brunoerg
Copy link
Contributor

@brunoerg brunoerg commented Apr 26, 2021 •
edited
Loading

This PR removes the progress bar (keeping only the percentage) on modal overlay

resolves #279

Before:
1

After:
2

@Bosch-0
Copy link

Bosch-0 commented Apr 28, 2021

tACK 61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)

@hebasto hebasto added the Design label Apr 28, 2021
@hebasto
Copy link
Member

hebasto commented Apr 29, 2021 •
edited
Loading

Concept ACK.

@brunoerg

For such PRs it is convenient to have screenshots "before/master" and "after/PR" posted in the PR description.

UPDATE. Also you can use on of these words instead of "See" to link to the issue :)

@brunoerg
Copy link
Contributor Author

brunoerg commented Apr 29, 2021

@hebasto Thanks a lot! :)

@Bosch-0 Bosch-0 mentioned this pull request Apr 30, 2021
Closed
jarolrod
jarolrod reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 61fd8fe

tested on macOS 11.3 Qt 5.15.2. Patch looks correct

Master PR
Screen Shot 2021-04-30 at 1 29 10 AM Screen Shot 2021-04-30 at 1 16 40 AM

@maflcko maflcko merged commit 480bf01 into bitcoin-core:master Apr 30, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 30, 2021
Merge bitcoin-core/gui#300: Remove progress bar on modal overlay
789e336 
61fd8fe Remove progress bar on modal overlay (bruno)

Pull request description:

  This PR removes the progress bar (keeping only the percentage) on modal overlay

  resolves #279

  Before:
  ![1](https://user-images.githubusercontent.com/19480819/116625265-bde65000-a91f-11eb-93ee-72474fc8dd67.PNG)

  After:
  ![2](https://user-images.githubusercontent.com/19480819/116625272-c2126d80-a91f-11eb-80b7-839703f03f87.PNG)

ACKs for top commit:
  Bosch-0:
    tACK bitcoin-core/gui@61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)
  jarolrod:
    tACK 61fd8fe

Tree-SHA512: 96d72f168b26e950ce37e9f489bcbcc608473c44bce3be127ccd47d17b7642fa234d314596186ee16b430d943575c312d84133425507a17ae7ac58ecae986639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#300: Remove progress bar on modal overlay
81ece34 
61fd8fe Remove progress bar on modal overlay (bruno)

Pull request description:

  This PR removes the progress bar (keeping only the percentage) on modal overlay

  resolves dashpay#279

  Before:
  ![1](https://user-images.githubusercontent.com/19480819/116625265-bde65000-a91f-11eb-93ee-72474fc8dd67.PNG)

  After:
  ![2](https://user-images.githubusercontent.com/19480819/116625272-c2126d80-a91f-11eb-80b7-839703f03f87.PNG)

ACKs for top commit:
  Bosch-0:
    tACK bitcoin-core/gui@61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)
  jarolrod:
    tACK 61fd8fe

Tree-SHA512: 96d72f168b26e950ce37e9f489bcbcc608473c44bce3be127ccd47d17b7642fa234d314596186ee16b430d943575c312d84133425507a17ae7ac58ecae986639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#300: Remove progress bar on modal overlay
625cd26 
61fd8fe Remove progress bar on modal overlay (bruno)

Pull request description:

  This PR removes the progress bar (keeping only the percentage) on modal overlay

  resolves dashpay#279

  Before:
  ![1](https://user-images.githubusercontent.com/19480819/116625265-bde65000-a91f-11eb-93ee-72474fc8dd67.PNG)

  After:
  ![2](https://user-images.githubusercontent.com/19480819/116625272-c2126d80-a91f-11eb-80b7-839703f03f87.PNG)

ACKs for top commit:
  Bosch-0:
    tACK bitcoin-core/gui@61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)
  jarolrod:
    tACK 61fd8fe

Tree-SHA512: 96d72f168b26e950ce37e9f489bcbcc608473c44bce3be127ccd47d17b7642fa234d314596186ee16b430d943575c312d84133425507a17ae7ac58ecae986639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#300: Remove progress bar on modal overlay
fe5174d 
61fd8fe Remove progress bar on modal overlay (bruno)

Pull request description:

  This PR removes the progress bar (keeping only the percentage) on modal overlay

  resolves dashpay#279

  Before:
  ![1](https://user-images.githubusercontent.com/19480819/116625265-bde65000-a91f-11eb-93ee-72474fc8dd67.PNG)

  After:
  ![2](https://user-images.githubusercontent.com/19480819/116625272-c2126d80-a91f-11eb-80b7-839703f03f87.PNG)

ACKs for top commit:
  Bosch-0:
    tACK bitcoin-core/gui@61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)
  jarolrod:
    tACK 61fd8fe

Tree-SHA512: 96d72f168b26e950ce37e9f489bcbcc608473c44bce3be127ccd47d17b7642fa234d314596186ee16b430d943575c312d84133425507a17ae7ac58ecae986639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#300: Remove progress bar on modal overlay
0b37d57 
61fd8fe Remove progress bar on modal overlay (bruno)

Pull request description:

  This PR removes the progress bar (keeping only the percentage) on modal overlay

  resolves dashpay#279

  Before:
  ![1](https://user-images.githubusercontent.com/19480819/116625265-bde65000-a91f-11eb-93ee-72474fc8dd67.PNG)

  After:
  ![2](https://user-images.githubusercontent.com/19480819/116625272-c2126d80-a91f-11eb-80b7-839703f03f87.PNG)

ACKs for top commit:
  Bosch-0:
    tACK bitcoin-core/gui@61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)
  jarolrod:
    tACK 61fd8fe

Tree-SHA512: 96d72f168b26e950ce37e9f489bcbcc608473c44bce3be127ccd47d17b7642fa234d314596186ee16b430d943575c312d84133425507a17ae7ac58ecae986639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#300: Remove progress bar on modal overlay
d36b1e0 
61fd8fe Remove progress bar on modal overlay (bruno)

Pull request description:

  This PR removes the progress bar (keeping only the percentage) on modal overlay

  resolves dashpay#279

  Before:
  ![1](https://user-images.githubusercontent.com/19480819/116625265-bde65000-a91f-11eb-93ee-72474fc8dd67.PNG)

  After:
  ![2](https://user-images.githubusercontent.com/19480819/116625272-c2126d80-a91f-11eb-80b7-839703f03f87.PNG)

ACKs for top commit:
  Bosch-0:
    tACK bitcoin-core/gui@61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)
  jarolrod:
    tACK 61fd8fe

Tree-SHA512: 96d72f168b26e950ce37e9f489bcbcc608473c44bce3be127ccd47d17b7642fa234d314596186ee16b430d943575c312d84133425507a17ae7ac58ecae986639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 21, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#300: Remove progress bar on modal overlay
a8cc27f 
61fd8fe Remove progress bar on modal overlay (bruno)

Pull request description:

  This PR removes the progress bar (keeping only the percentage) on modal overlay

  resolves dashpay#279

  Before:
  ![1](https://user-images.githubusercontent.com/19480819/116625265-bde65000-a91f-11eb-93ee-72474fc8dd67.PNG)

  After:
  ![2](https://user-images.githubusercontent.com/19480819/116625272-c2126d80-a91f-11eb-80b7-839703f03f87.PNG)

ACKs for top commit:
  Bosch-0:
    tACK bitcoin-core/gui@61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)
  jarolrod:
    tACK 61fd8fe

Tree-SHA512: 96d72f168b26e950ce37e9f489bcbcc608473c44bce3be127ccd47d17b7642fa234d314596186ee16b430d943575c312d84133425507a17ae7ac58ecae986639
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 24, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#300: Remove progress bar on modal overlay
621e245 
61fd8fe Remove progress bar on modal overlay (bruno)

Pull request description:

  This PR removes the progress bar (keeping only the percentage) on modal overlay

  resolves dashpay#279

  Before:
  ![1](https://user-images.githubusercontent.com/19480819/116625265-bde65000-a91f-11eb-93ee-72474fc8dd67.PNG)

  After:
  ![2](https://user-images.githubusercontent.com/19480819/116625272-c2126d80-a91f-11eb-80b7-839703f03f87.PNG)

ACKs for top commit:
  Bosch-0:
    tACK bitcoin-core/gui@61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)
  jarolrod:
    tACK 61fd8fe

Tree-SHA512: 96d72f168b26e950ce37e9f489bcbcc608473c44bce3be127ccd47d17b7642fa234d314596186ee16b430d943575c312d84133425507a17ae7ac58ecae986639
kwvg pushed a commit to kwvg/dash that referenced this pull request Oct 12, 2021
@kwvg
Merge bitcoin-core/gui#300: Remove progress bar on modal overlay
d126bdb 
61fd8fe Remove progress bar on modal overlay (bruno)

Pull request description:

  This PR removes the progress bar (keeping only the percentage) on modal overlay

  resolves dashpay#279

  Before:
  ![1](https://user-images.githubusercontent.com/19480819/116625265-bde65000-a91f-11eb-93ee-72474fc8dd67.PNG)

  After:
  ![2](https://user-images.githubusercontent.com/19480819/116625272-c2126d80-a91f-11eb-80b7-839703f03f87.PNG)

ACKs for top commit:
  Bosch-0:
    tACK bitcoin-core/gui@61fd8fe on Windows 10. Unnecessary Progress bar no longer there :)
  jarolrod:
    tACK 61fd8fe

Tree-SHA512: 96d72f168b26e950ce37e9f489bcbcc608473c44bce3be127ccd47d17b7642fa234d314596186ee16b430d943575c312d84133425507a17ae7ac58ecae986639
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge 480bf01 into merged_master (Bitcoin PR bitcoin-core/gui#300)
222850a
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jarolrod jarolrod jarolrod left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Design

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unecessary progress bar

5 participants

@brunoerg @Bosch-0 @hebasto @jarolrod @maflcko