Fix up of Block Clock strings #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
|
jarolrod
reviewed
Feb 27, 2023
Contributor
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
Can you group the following into this PR, and update the PR title to something like: "Correct BlockClock states text" (or something similar)
This should be "Please wait" per the design file
gui-qml/src/qml/components/BlockClock.qml
Line 129 in 7b168da
johnny9
changed the title
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
628c4de qml: fix capitalization on BlockClock Please wait string (johnny9) 49e7097 qml: use Estimating as the default string for remainingSyncTime (johnny9) Pull request description: [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/275) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/275) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/275) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/275) ACKs for top commit: jarolrod: ACK 628c4de Tree-SHA512: 8eed140b96340c382bc47b170ec5e52879f21b6ed96f2bf63ccd7bde730361df7191a809f869c9ea76cdec1afa5ee6e1666d3637987059552908dc5d5c26cd49
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
628c4ded92b620cdd7610ed06888182330061f43 qml: fix capitalization on BlockClock Please wait string (johnny9) 49e709754237c024600791367095a2b41012513d qml: use Estimating as the default string for remainingSyncTime (johnny9) Pull request description: [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/275) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/275) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/275) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/275) ACKs for top commit: jarolrod: ACK 628c4ded92b620cdd7610ed06888182330061f43 Tree-SHA512: 8eed140b96340c382bc47b170ec5e52879f21b6ed96f2bf63ccd7bde730361df7191a809f869c9ea76cdec1afa5ee6e1666d3637987059552908dc5d5c26cd49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.