Introduce reusable CaretRightButton, bind color to Setting stateColor #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
force-pushed
the
right-caret-button-states
branch
from
37d2019 to
33b68b3
Compare
Contributor
Author
Member
It has been just merged. Rebase? |
This encapsulates a commonly used button into a reusable component.
jarolrod
force-pushed
the
right-caret-button-states
branch
from
33b68b3 to
624d985
Compare
johnny9
approved these changes
Feb 9, 2023
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
…bind color to Setting stateColor b880f30 qml: use CaretRightButton, bind to Setting state color (jarolrod) 5397e99 qml: add CaretRightButton component (jarolrod) Pull request description: This finishes setting up all current Settings to be able to respond to the Setting state. | Filled | Hover | Active | | ------ | ----- | ------ | | <img width="454" alt="Screen Shot 2023-02-01 at 2 12 02 AM" src="https://user-images.githubusercontent.com/23396902/215975827-b4a3b60c-f19b-483d-94a9-8c2191e48253.png"> | <img width="454" alt="Screen Shot 2023-02-01 at 2 12 11 AM" src="https://user-images.githubusercontent.com/23396902/215975854-d038ee42-4bda-4a87-8e04-bf76ebabb5b5.png"> | <img width="454" alt="Screen Shot 2023-02-01 at 2 12 19 AM" src="https://user-images.githubusercontent.com/23396902/215975871-d6a5b120-e53b-4b00-b5c4-7be1872a9e05.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/242) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/242) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/242) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/242) ACKs for top commit: johnny9: ACK b880f30 Tree-SHA512: 864312d8f8702ad30050cbb82ff7944e2bcbaedc29999fcf728e625214b59b26320ee600c674703246fb4e852f957b26bf7982716b14419501c14dcd38879e3f
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
…bind color to Setting stateColor b880f3081758eaa1d654a702321ca53cb73c4568 qml: use CaretRightButton, bind to Setting state color (jarolrod) 5397e9945ca68c95456bbca1a2302220934a7614 qml: add CaretRightButton component (jarolrod) Pull request description: This finishes setting up all current Settings to be able to respond to the Setting state. | Filled | Hover | Active | | ------ | ----- | ------ | | <img width="454" alt="Screen Shot 2023-02-01 at 2 12 02 AM" src="https://user-images.githubusercontent.com/23396902/215975827-b4a3b60c-f19b-483d-94a9-8c2191e48253.png"> | <img width="454" alt="Screen Shot 2023-02-01 at 2 12 11 AM" src="https://user-images.githubusercontent.com/23396902/215975854-d038ee42-4bda-4a87-8e04-bf76ebabb5b5.png"> | <img width="454" alt="Screen Shot 2023-02-01 at 2 12 19 AM" src="https://user-images.githubusercontent.com/23396902/215975871-d6a5b120-e53b-4b00-b5c4-7be1872a9e05.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/242) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/242) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/242) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/242) ACKs for top commit: johnny9: ACK b880f3081758eaa1d654a702321ca53cb73c4568 Tree-SHA512: 864312d8f8702ad30050cbb82ff7944e2bcbaedc29999fcf728e625214b59b26320ee600c674703246fb4e852f957b26bf7982716b14419501c14dcd38879e3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes setting up all current Settings to be able to respond to the Setting state.