Make External Link settings icon follow the design file specs

[jarolrod]

This replaces the current export icon we have (export-filled) for the export-outline icon, as that is what the design file now specifies. The new icon has been passed through the optimize-png.py script, which output the following:

optimizing export.png... done
summary:
+++++++++++++++++
export.png
  size diff from: 1371 to: 785
  old sha256: c93640af06071bcee055727bcfd01f8576d657260a385035dac8f2f1568cf571
  new sha256: c0605b933dfaae15b26254d08d11d2e9e9e4b20d5a9748386cd9a9f680502266

completed. Checksum stable: False. Total reduction: 586 bytes

Additionally, this adjusts the spacing between the external link text and the icon in order to better match the design file

master

light	dark

pr

light	dark

layout

external icon	right caret

[johnny9]

The new icon expanded the spacing on the layout. I think adjusting spacing from 20 to 15 in AboutOptions and Settings.qml fixes it but unsure of the side effects of that with the other views

[jarolrod]

@johnny9 @GBKS

Is that really an issue? There's no clear spec for how tall a setting should be, for example settings with descriptions are taller

[GBKS]

List items can indeed scale vertically to fit whatever content needs to be shown. I tried to shoot for a default height of 50px for items that have just one line of text and icon left/right. 44 is the minimum hit area recommended for mobile, and 50 is just a little more convenient. Too much space, and you end up with pretty tall screens with somewhat low information density.

[hebasto]

Rebase?

[jarolrod]

Updated from 3874d63 to 515e2fa, compare

Changes:

• rebased over main to resolve conflicts
• Fixed layout issue by getting us as close to the design file as I can without spending too many more hours over 2 pixels :D

[johnny9]

ACK 515e2fa