qml: make external links follow the specs in the design file

Author: jarolrod

src/qml/components/AboutOptions.qml

@@ -15,7 +15,6 @@ ColumnLayout {
         actionItem: ExternalLink {
             description: "bitcoincore.org"
             link: "https://bitcoincore.org"
-            iconSource: "image://images/caret-right"
         }
     }
     Setting {
@@ -24,7 +23,6 @@ ColumnLayout {
         actionItem: ExternalLink {
             description: "github.com/bitcoin/bitcoin"
             link: "https://github.com/bitcoin/bitcoin"
-            iconSource: "image://images/caret-right"
         }
     }
     Setting {
@@ -33,7 +31,6 @@ ColumnLayout {
         actionItem: ExternalLink {
             description: "MIT"
             link: "https://opensource.org/licenses/MIT"
-            iconSource: "image://images/caret-right"
         }
     }
     Setting {
@@ -43,6 +40,8 @@ ColumnLayout {
             description: "v22.99.0-1e7564eca8a6"
             link: "https://bitcoin.org/en/download"
             iconSource: "image://images/caret-right"
+            iconWidth: 18
+            iconHeight: 18
         }
     }
     Setting {

src/qml/controls/ExternalLink.qml

@@ -11,9 +11,9 @@ Control {
     required property string link
     property string description: ""
     property int descriptionSize: 18
-    property url iconSource: ""
-    property int iconWidth: 18
-    property int iconHeight: 18
+    property url iconSource: "image://images/export"
+    property int iconWidth: 22
+    property int iconHeight: 22
 
     contentItem: RowLayout {
         spacing: 0
@@ -27,23 +27,18 @@ Control {
                 font.styleName: "Regular"
                 font.pixelSize: root.descriptionSize
                 color: Theme.color.neutral7
-                textFormat: Text.RichText
-                text: "<style>a:link { color: " + Theme.color.neutral7 + "; text-decoration: none;}</style>" + "<a href=\"" + link + "\">" + root.description + "</a>"
+                text: root.description
                 onLinkActivated: Qt.openUrlExternally(link)
             }
         }
-        Loader {
-            Layout.fillWidth: true
-            active: root.iconSource.toString().length > 0
-            visible: active
-            sourceComponent: Button {
-                icon.source: root.iconSource
-                icon.color: Theme.color.neutral9
-                icon.height: root.iconHeight
-                icon.width: root.iconWidth
-                background: null
-                onClicked: Qt.openUrlExternally(link)
-            }
+        Button {
+            leftPadding: 0
+            icon.source: root.iconSource
+            icon.color: Theme.color.neutral9
+            icon.height: root.iconHeight
+            icon.width: root.iconWidth
+            background: null
+            onClicked: Qt.openUrlExternally(link)
         }
     }
 }