Introduce Proxy settings view #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, I'll add this to Figma. Looking at the "IP and port" input, I'd just have kept this as a single input field, I think it's straightforward enough like that. The hit areas are also really small, had to tap a few times until the inputs were selected. And now (sorry) for some obnoxious feedback from me trying to break things. Something I noticed is that the port input can accepts line breaks, messing with the layout.
I can also enter super long text, breaking things further.
|
Closed
SettingsConnection now contains a SwipeView where you can access the connection settings then press on "Proxy Settings" to get to the Proxy configuration page. There is no use-case for Proxy settings to be shown outside of the context of connection settings.
jarolrod
force-pushed
the
proxy-page-view
branch
from
8fc193d to
af66daa
Compare
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
e932e79 qml: rework SettingsConnection page to include Proxy settings (jarolrod) 5d24f86 qml: introduce proxy setting components and pages (jarolrod) Pull request description: Introduces the components and views that make up the proxy settings page. Missing options handling wiring, as well as the gray box that signals the current status/activation of specified proxy settings. Based on these designs: [proxy designs](https://www.figma.com/file/ek8w3n3upbluw5UL2lGhRx/Bitcoin-Core-App-Design?node-id=6266%3A23933&t=fVYCyV3AXZLRXxpB-4) | light | dark | | ----- | ---- | | <img width="752" alt="Screen Shot 2023-02-17 at 1 15 52 AM" src="https://user-images.githubusercontent.com/23396902/219564274-4156bdff-6d1e-48df-aad1-790800cd1622.png"> | <img width="752" alt="Screen Shot 2023-02-17 at 1 15 28 AM" src="https://user-images.githubusercontent.com/23396902/219564290-2fc83d8c-308d-496a-8de5-34c992701336.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/223) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/223) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/223) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/223) ACKs for top commit: johnny9: ACK e932e79 Tree-SHA512: 86e56088ed63c63b9885a309a4e9cf3f1635e91b860b3028feafa5801278d859bdd5c023db74f25c6fdf29a154fd4f3fed51877675dd09656765441cc814a22e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the components and views that make up the proxy settings page. Missing options handling wiring, as well as the gray box that signals the current status/activation of specified proxy settings. Based on these designs: proxy designs