Skip to content

Make untranslatable values, untranslatable #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Jan 16, 2023

This picks up and replaces #140

Rebases and removes one more occurrence of a value qsTr() on an untranslatable value.

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK.

@jarolrod jarolrod force-pushed the untranslatable-values branch from 35fe19d to d528468 Compare January 17, 2023 00:42
@jarolrod
Copy link
Member Author

updated from 35fe19d to d528468

Changes: Leave the prune target text as a qsTr()

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d528468

@hebasto hebasto merged commit 6e7fd70 into bitcoin-core:main Jan 17, 2023
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants