Show a check icon when an OptionButton is selected #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2022
Merged
hebasto
added a commit
that referenced
this pull request
Dec 14, 2022
76287e4 qml: introduce check icon (Jarol Rodriguez) Pull request description: Introduces the `check` icon from the Bitcoin Icons set. The svg is taken from optimized/filled and the png has been ran through the optimization script. The current production use-case of this icon will be for the [check icon](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=5733%3A139691&t=9577jMhj1i9bCaJi-0) that is part of the current design for the OptionButton control. The [check icon](https://github.com/BitcoinDesign/Bitcoin-Icons/blob/main/optimized/filled/bitcoin-check.svg) was taken from the [Bitcoin-Icons Repo](https://github.com/BitcoinDesign/Bitcoin-Icons). This was used to generate a PNG of 128x128 size using inkscape. The resulting PNG was then run through the [optimize-pngs.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py) script. The output of the script is as follows: ``` optimizing check.png... done summary: +++++++++++++++++ check.png size diff from: 1291 to: 829 old sha256: 4436036d05b03fb55ad86e684beb125aa4805b78c4b4d276e5a372ffe5ef2941 new sha256: c8f95de9fa3c98fa318f0eaa55e658f61d6a19e78761b2ccd774f9f9ba6d8ee4 completed. Checksum stable: False. Total reduction: 462 bytes ``` You can demo this by testing #205 [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/204) ACKs for top commit: johnny9: ACK 76287e4 Tree-SHA512: 37bdc1153774226f6ca53694c8098a3f6eba3a9ef157ce49db1da7afdb87b2d9b6afbb82c45e8f269d91fc9c56747bba8d6854c3001b52e8115aeceaff4106c5
Member
Merged :) |
This does away with a loadable detail and places a check mark icon in it's place.
jarolrod
force-pushed
the
checkable-configuration-buttons
branch
from
4d8bf17 to
2c8ac00
Compare
Contributor
Author
Contributor
Author
hebasto
added a commit
that referenced
this pull request
Dec 17, 2022
a9812ff qml: storage options description fixups (Jarol Rodriguez) Pull request description: Based on #205 so as to not conflict. Only PR commit is ac13dc1 Performs small text fixups to the storage options to fall in line with the designs. Only differs from the [figma designs](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=3288%3A72160&t=ttpjexCKgAerUbB2-0) by changing `For regular wallet use.` to `For simple wallet use.` in the StorageAmount OptionsButton control. ### Master | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 2 12 47 AM" src="https://user-images.githubusercontent.com/23396902/207529947-346fcd7b-4a7c-42bd-aee6-4784b1fbb43a.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 2 12 52 AM" src="https://user-images.githubusercontent.com/23396902/207529982-e4e3faa1-7e24-4460-b5da-1d87ee69dc17.png"> | ### PR | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 2 08 00 AM" src="https://user-images.githubusercontent.com/23396902/207530072-3da9a872-7a76-4ba7-86b0-ba7b3fc48287.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 2 08 18 AM" src="https://user-images.githubusercontent.com/23396902/207530101-5503aa6b-ac23-4d95-976d-7f37f4fb50f0.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/206) ACKs for top commit: johnny9: ACK a9812ff Tree-SHA512: 3abaf8f6a020823974a60dca1146069a2cdc41c80a9d41621242538251327642678b60907604745a36f86666f7f4af87d09f327305239cdf4090af3be8ced9b3
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
This does away with a loadable detail and places a check mark icon in it's place. Github-Pull: bitcoin-core#205 Rebased-From: 2c8ac00
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
This does away with a loadable detail and places a check mark icon in it's place. Github-Pull: bitcoin-core#205 Rebased-From: 2c8ac00
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
This does away with a loadable detail and places a check mark icon in it's place. Github-Pull: bitcoin-core#205 Rebased-From: 2c8ac00
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
ee18b22 qml: introduce check icon (Jarol Rodriguez) Pull request description: Introduces the `check` icon from the Bitcoin Icons set. The svg is taken from optimized/filled and the png has been ran through the optimization script. The current production use-case of this icon will be for the [check icon](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=5733%3A139691&t=9577jMhj1i9bCaJi-0) that is part of the current design for the OptionButton control. The [check icon](https://github.com/BitcoinDesign/Bitcoin-Icons/blob/main/optimized/filled/bitcoin-check.svg) was taken from the [Bitcoin-Icons Repo](https://github.com/BitcoinDesign/Bitcoin-Icons). This was used to generate a PNG of 128x128 size using inkscape. The resulting PNG was then run through the [optimize-pngs.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py) script. The output of the script is as follows: ``` optimizing check.png... done summary: +++++++++++++++++ check.png size diff from: 1291 to: 829 old sha256: 4436036d05b03fb55ad86e684beb125aa4805b78c4b4d276e5a372ffe5ef2941 new sha256: c8f95de9fa3c98fa318f0eaa55e658f61d6a19e78761b2ccd774f9f9ba6d8ee4 completed. Checksum stable: False. Total reduction: 462 bytes ``` You can demo this by testing bitcoin-core/gui-qml#205 [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/204) ACKs for top commit: johnny9: ACK ee18b22 Tree-SHA512: 37bdc1153774226f6ca53694c8098a3f6eba3a9ef157ce49db1da7afdb87b2d9b6afbb82c45e8f269d91fc9c56747bba8d6854c3001b52e8115aeceaff4106c5
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
…n is selected c2db455 qml: add check mark to OptionButton control (Jarol Rodriguez) Pull request description: This does away with the current detail loader and replaces it with a `check` icon. We no longer have a use case for a customizable detail within the `OptionButton` control, only a need for the check icon when the button is selected. | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 1 21 10 AM" src="https://user-images.githubusercontent.com/23396902/207523321-16c12aca-af95-493b-9870-e6916d836ece.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 1 21 21 AM" src="https://user-images.githubusercontent.com/23396902/207523343-5935d940-eadf-47d8-9266-60107ec7a292.png"> | | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 1 21 42 AM" src="https://user-images.githubusercontent.com/23396902/207523425-f68617c3-dee1-45d6-abe9-19cd9ead58f7.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 1 21 48 AM" src="https://user-images.githubusercontent.com/23396902/207523466-fed59c46-11db-4bb7-8ea5-529894b2d365.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/205) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/205) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/205) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/205) ACKs for top commit: johnny9: ACK c2db455 Tree-SHA512: dc92eae43958bea7855ed08d2c016c5c3faa9072ff28f2207dc9aef21252077bffffeb4b3dbb2084d87d1d33b53659483614282cf0f67be414925c4d79e9418d
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
20b23bc qml: storage options description fixups (Jarol Rodriguez) Pull request description: Based on bitcoin-core/gui-qml#205 so as to not conflict. Only PR commit is ac13dc1da3088099ca9c020f980d3245ac2a3084 Performs small text fixups to the storage options to fall in line with the designs. Only differs from the [figma designs](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=3288%3A72160&t=ttpjexCKgAerUbB2-0) by changing `For regular wallet use.` to `For simple wallet use.` in the StorageAmount OptionsButton control. ### Master | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 2 12 47 AM" src="https://user-images.githubusercontent.com/23396902/207529947-346fcd7b-4a7c-42bd-aee6-4784b1fbb43a.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 2 12 52 AM" src="https://user-images.githubusercontent.com/23396902/207529982-e4e3faa1-7e24-4460-b5da-1d87ee69dc17.png"> | ### PR | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 2 08 00 AM" src="https://user-images.githubusercontent.com/23396902/207530072-3da9a872-7a76-4ba7-86b0-ba7b3fc48287.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 2 08 18 AM" src="https://user-images.githubusercontent.com/23396902/207530101-5503aa6b-ac23-4d95-976d-7f37f4fb50f0.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/206) ACKs for top commit: johnny9: ACK 20b23bc Tree-SHA512: 3abaf8f6a020823974a60dca1146069a2cdc41c80a9d41621242538251327642678b60907604745a36f86666f7f4af87d09f327305239cdf4090af3be8ced9b3
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
ee18b22f51444fcc69517b0ae7bc232e85dce1db qml: introduce check icon (Jarol Rodriguez) Pull request description: Introduces the `check` icon from the Bitcoin Icons set. The svg is taken from optimized/filled and the png has been ran through the optimization script. The current production use-case of this icon will be for the [check icon](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=5733%3A139691&t=9577jMhj1i9bCaJi-0) that is part of the current design for the OptionButton control. The [check icon](https://github.com/BitcoinDesign/Bitcoin-Icons/blob/main/optimized/filled/bitcoin-check.svg) was taken from the [Bitcoin-Icons Repo](https://github.com/BitcoinDesign/Bitcoin-Icons). This was used to generate a PNG of 128x128 size using inkscape. The resulting PNG was then run through the [optimize-pngs.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py) script. The output of the script is as follows: ``` optimizing check.png... done summary: +++++++++++++++++ check.png size diff from: 1291 to: 829 old sha256: 4436036d05b03fb55ad86e684beb125aa4805b78c4b4d276e5a372ffe5ef2941 new sha256: c8f95de9fa3c98fa318f0eaa55e658f61d6a19e78761b2ccd774f9f9ba6d8ee4 completed. Checksum stable: False. Total reduction: 462 bytes ``` You can demo this by testing bitcoin-core/gui-qml#205 [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/204) ACKs for top commit: johnny9: ACK ee18b22f51444fcc69517b0ae7bc232e85dce1db Tree-SHA512: 37bdc1153774226f6ca53694c8098a3f6eba3a9ef157ce49db1da7afdb87b2d9b6afbb82c45e8f269d91fc9c56747bba8d6854c3001b52e8115aeceaff4106c5
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
…n is selected c2db45558fbb6e91f052c2d3c1e5dfe0417ca89c qml: add check mark to OptionButton control (Jarol Rodriguez) Pull request description: This does away with the current detail loader and replaces it with a `check` icon. We no longer have a use case for a customizable detail within the `OptionButton` control, only a need for the check icon when the button is selected. | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 1 21 10 AM" src="https://user-images.githubusercontent.com/23396902/207523321-16c12aca-af95-493b-9870-e6916d836ece.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 1 21 21 AM" src="https://user-images.githubusercontent.com/23396902/207523343-5935d940-eadf-47d8-9266-60107ec7a292.png"> | | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 1 21 42 AM" src="https://user-images.githubusercontent.com/23396902/207523425-f68617c3-dee1-45d6-abe9-19cd9ead58f7.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 1 21 48 AM" src="https://user-images.githubusercontent.com/23396902/207523466-fed59c46-11db-4bb7-8ea5-529894b2d365.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/205) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/205) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/205) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/205) ACKs for top commit: johnny9: ACK c2db45558fbb6e91f052c2d3c1e5dfe0417ca89c Tree-SHA512: dc92eae43958bea7855ed08d2c016c5c3faa9072ff28f2207dc9aef21252077bffffeb4b3dbb2084d87d1d33b53659483614282cf0f67be414925c4d79e9418d
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
20b23bcc2b7fb32428fb617a7f9b495d7f6a805f qml: storage options description fixups (Jarol Rodriguez) Pull request description: Based on bitcoin-core/gui-qml#205 so as to not conflict. Only PR commit is ac13dc1da3088099ca9c020f980d3245ac2a3084 Performs small text fixups to the storage options to fall in line with the designs. Only differs from the [figma designs](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=3288%3A72160&t=ttpjexCKgAerUbB2-0) by changing `For regular wallet use.` to `For simple wallet use.` in the StorageAmount OptionsButton control. ### Master | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 2 12 47 AM" src="https://user-images.githubusercontent.com/23396902/207529947-346fcd7b-4a7c-42bd-aee6-4784b1fbb43a.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 2 12 52 AM" src="https://user-images.githubusercontent.com/23396902/207529982-e4e3faa1-7e24-4460-b5da-1d87ee69dc17.png"> | ### PR | a | b | | - | - | | <img width="752" alt="Screen Shot 2022-12-14 at 2 08 00 AM" src="https://user-images.githubusercontent.com/23396902/207530072-3da9a872-7a76-4ba7-86b0-ba7b3fc48287.png"> | <img width="752" alt="Screen Shot 2022-12-14 at 2 08 18 AM" src="https://user-images.githubusercontent.com/23396902/207530101-5503aa6b-ac23-4d95-976d-7f37f4fb50f0.png"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/206) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/206) ACKs for top commit: johnny9: ACK 20b23bcc2b7fb32428fb617a7f9b495d7f6a805f Tree-SHA512: 3abaf8f6a020823974a60dca1146069a2cdc41c80a9d41621242538251327642678b60907604745a36f86666f7f4af87d09f327305239cdf4090af3be8ced9b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does away with the current detail loader and replaces it with a
checkicon. We no longer have a use case for a customizable detail within theOptionButtoncontrol, only a need for the check icon when the button is selected.