-
Notifications
You must be signed in to change notification settings - Fork 50
Remove extra layout properties #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Based on PR #197 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
Tested that these are indeed redundant, will re-review when the pr this is based on is merged.
f338980
to
c1de34c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
There's one more unnecessary fillWidth in onboarding02
Layout.fillWidth: true |
c1de34c
to
4d94378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 4d94378, I have reviewed the code and it looks OK, I agree it can be merged.
Github-Pull: bitcoin-core#201 Rebased-From: 4d94378
Github-Pull: bitcoin-core#201 Rebased-From: 4d94378
Github-Pull: bitcoin-core#201 Rebased-From: 4d94378
After consolidation of the Onboarding pages, there are some leftover Layout properties that are no longer needed.