Skip to content

Remove extra layout properties #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

johnny9
Copy link
Collaborator

@johnny9 johnny9 commented Dec 8, 2022

After consolidation of the Onboarding pages, there are some leftover Layout properties that are no longer needed.

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@johnny9
Copy link
Collaborator Author

johnny9 commented Dec 8, 2022

Based on PR #197

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Tested that these are indeed redundant, will re-review when the pr this is based on is merged.

@johnny9 johnny9 force-pushed the extra-layout-props branch from f338980 to c1de34c Compare December 9, 2022 18:07
@johnny9
Copy link
Collaborator Author

johnny9 commented Dec 9, 2022

Update from f338980 to c1de34c:

  • rebased with main

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

There's one more unnecessary fillWidth in onboarding02

@johnny9
Copy link
Collaborator Author

johnny9 commented Dec 10, 2022

Update from c1de34c to 4d94378

  • Removed fillWidth from onboarding02

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4d94378, I have reviewed the code and it looks OK, I agree it can be merged.

@hebasto hebasto merged commit 397793c into bitcoin-core:main Dec 10, 2022
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants