Skip to content

Conversation

johnny9
Copy link
Collaborator

@johnny9 johnny9 commented Nov 23, 2022

Addresses the issue with the button stretching too far on a wide mobile/tablet.

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@johnny9 johnny9 changed the title qml: constrain ContinueButton width to 300 pixels Constrain ContinueButton width to 300 pixels Nov 23, 2022
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

I did notice that on mobile the continue button is wider than the 300px

@hebasto
Copy link
Member

hebasto commented Dec 8, 2022

Rebase?

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2b4f905

Tested on mobile and android, welcome change to adhere to the design specs.

@hebasto hebasto merged commit 98038bb into bitcoin-core:main Dec 10, 2022
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
johnny9 pushed a commit to johnny9/bitcoin-core-app that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants