-
Notifications
You must be signed in to change notification settings - Fork 49
Constrain ContinueButton width to 300 pixels #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
I did notice that on mobile the continue button is wider than the 300px
Rebase? |
48eed06
to
2b4f905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2b4f905
Tested on mobile and android, welcome change to adhere to the design specs.
Github-Pull: bitcoin-core#190 Rebased-From: 2b4f905
Github-Pull: bitcoin-core#190 Rebased-From: 2b4f905
Github-Pull: bitcoin-core#190 Rebased-From: 2b4f905
… pixels 511f494 qml: constrain ContinueButton width to 300 pixels (Johnny Carlson) Pull request description: Addresses the issue with the button stretching too far on a wide mobile/tablet. [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/190) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/190) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/190) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/190) ACKs for top commit: jarolrod: ACK 511f494 Tree-SHA512: b65c0368511e7fda7c2aa134513b16cf7e0e9e72440746fb46d53273cf14c849d410ccb20bfef2451b88247add7980f214ba19373c645005c830b20911134a80
Addresses the issue with the button stretching too far on a wide mobile/tablet.