This repository was archived by the owner on Oct 30, 2023. It is now read-only.
Add side-effect type to the margin new order #291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
The reason I went with separate classes for MarginNewOrder and MarginNewOrderResponse is because adding the new properties to NewOrder and NewOrderResponse would have made they usage confusing. Besides sideEffectType, the MarginNewOrder should also have the isIsolated property, which is currently not implemented. The same holds for MarginNewOrderResponse. I did not inherit MarginNewOrder from NewOrder and MarginNewOrderResponse from NewOrderResponse since it's not clear that this is the relationship between those. I could have extracted the common properties to a base class, but did not really see the benefit.
See the documentation change log for when the change was done: