Add ws subscriptions for all book tickers stream and ticker stream by eugenpodaru · Pull Request #290 · binance-exchange/binance-java-api · GitHub

This repository was archived by the owner on Oct 30, 2023. It is now read-only.

eugenpodaru commented Nov 12, 2020

What does this PR do?

Add the all book ticker stream subscription to BinanceApiWebSocketClient
Add the symbol ticker stream subscription to BinanceApiWebSocketClient
Refactor some code.

Where should the reviewer start?

src/main/java/com/binance/api/client/domain/event/BookTickerEvent.java
src/main/java/com/binance/api/client/domain/event/TickerEvent.java
src/main/java/com/binance/api/client/BinanceApiWebSocketClient.java
src/main/java/com/binance/api/client/impl/BinanceApiWebSocketClientImpl.java

How should this be manually tested?

Subscribing to BinanceApiWebSocketClient.onAllBookTickersEvent
Subscribing to BinanceApiWebSocketClient.onTickerEvent

Any background context you want to provide?

eugenpodaru added 3 commits

November 13, 2020 00:34


          Add ws allBookTickersEvent and tickerEvent

a3c0625


          Fix onAllBookTickersEvent

26638f2


          Add side-effect type to the margin new order

22dc5e5

joaopsilva merged commit 60eebc2 into binance-exchange:master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet