Skip to content
This repository was archived by the owner on Oct 30, 2023. It is now read-only.

Conversation

@jmresendiz
Copy link

What does this PR do?

  • Add the onBookTickerEvent WebSocket to BinanceApiWebSocketClient, for stream 'best price/qty on the order book for a symbol or symbols'. consider the endpoint [GET /api/v3/ticker/bookTicker](https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md)
  • Remove some un-used imports.

Where should the reviewer start?

  • src/main/java/com/binance/api/client/domain/event/BookTickerEvent.java
  • src/main/java/com/binance/api/client/BinanceApiWebSocketClient.java
  • src/main/java/com/binance/api/client/impl/BinanceApiWebSocketClientImpl.java

How should this be manually tested?

  1. Implementing a new BinanceApiWebSocketClient.onBookTickerEvent

Any background context you want to provide?

Implements the best price/qty on the order book for a symbol or symbols' websoccket.

image

Copy link
Member

@joaopsilva joaopsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joaopsilva joaopsilva merged commit 8d38e8e into binance-exchange:master Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants