OCO orders support and trade stream subscription added

[anydoby]

First of all, thank you for your brilliant effort at making this API. I was missing some features though. Maybe not entirely in line with your style, but I tried hard to code in a similar fashion.

For my humble trading needs I had to add support for creating OCO orders and also watching trade events. This MR includes this, hope this can be useful for the others.

[joaopsilva]

Thanks for this!

[joaopsilva]

Can you please just add an example?

[joaopsilva]

Can you please update the examples and the README.md? Thanks!

[anydoby]

Sure. I'm also going to add userData stream events for OCO orders. чт, 9 апр. 2020 г. в 00:06, João Silva <[email protected]>:

…

***@***.**** requested changes on this pull request. Can you please update the examples and the README.md? Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#262 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACME3B3LVUQKBPCSMOC2XO3RLTYQBANCNFSM4MEFHRMA> .

-- Best regards, Sergey Zolotaryov

[anydoby]

Hi João, I've added an example to the README and also monitoring for OCO trade updates. Now it is usable and I think mostly complete.

[TheLeBot]

@joaopsilva

Hi joaopsilva,

can you please resolve conflicts and merge so we can use that OCO stuff? Seems to be a very nice feature for trading at binance. I have seen another Pull request for similar implementation, but this from Sergey looks good enough to merge.

Thanks,
Andrej

[ghost]

Hello,

How can I get the new changes with OCO support? Does waiting conflicts/changes prevent to access it?
Regards, Thank you,

[anydoby]

Hello,

How can I get the new changes with OCO support? Does waiting conflicts/changes prevent to access it?
Regards, Thank you,

You can just take my fork :)

[joaopsilva]

Hi @alierturk122 @anydoby , yes, please just resolve the conflicts and I will merge it. Thanks.

[hawkeye-bot]

@joaopsilva @anydoby is anybody still going to merge this? I saw #341 as well for OCO orders, I think it would be good to get at least one of the two merged? Also, I noticed that a switch to netty has been made as well

[anydoby]

@joaopsilva @anydoby is anybody still going to merge this? I saw #341 as well for OCO orders, I think it would be good to get at least one of the two merged? Also, I noticed that a switch to netty has been made as well

You can use my fork as inspiration, I also added isolated margin client. It also uses netty as http client, which in my experience uses less memory and connections are more stable.

[hawkeye-bot]

@joaopsilva @anydoby is anybody still going to merge this? I saw #341 as well for OCO orders, I think it would be good to get at least one of the two merged? Also, I noticed that a switch to netty has been made as well

You can use my fork as inspiration, I also added isolated margin client. It also uses netty as http client, which in my experience uses less memory and connections are more stable.

@anydoby thanks for your reply! I actually tried out your fork, but for some websocket-data (like onAllMarketTickersEvent), the default max-frame-size used is causing problems. Other than that, your fork looks really good :) it would be good to feed back the improvements into the root repository :) as far as I can see, @joaopsilva is willing to include this merge request so it would be good to make that final push! If there's anything I can do to help please let me know, I'm happy to put in some effort to get this into the root repository!

[anydoby]

Good one @hoeckxer , I increased buffer to 512k, looks like this works fine. I think my fork deviated quite a lot from the original already to be just merged. But of course I'm happy to get it merged somehow (my bots work anyway, be it merged or not ;) )