This repository was archived by the owner on Oct 30, 2023. It is now read-only.
fixed market ticker event #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-andy-coates
left a comment
big-andy-coates
left a comment
There was a problem hiding this comment.
Thanks @Krasks - this is definitely an improvement from the rounding errors in the old version!
Just a suggestion, but did you think about maybe setting the fields to BigDecimal rather than String? I know this pattern is not followed elsewhere in the repo, but it Jackson does support it. Maybe the repo owners prefer Strings though...
|
@big-andy-coates - can we go with |
|
Fine by me - but then again, I’m just an interested party, not a committer ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.