Skip to content

CHECKOUT-2739: Move ScriptLoader source files into separate repository #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidchin merged 2 commits into from
Feb 26, 2018
Merged

CHECKOUT-2739: Move ScriptLoader source files into separate repository #1

davidchin merged 2 commits into from
Feb 26, 2018

Conversation

@davidchin
Copy link
Contributor

@davidchin davidchin commented Feb 26, 2018

What?

  • Move ScriptLoader module from checkout-sdk-js to script-loader-js.

Why?

  • For better modularity and reusability.

Testing / Proof

  • Unit

@bigcommerce/frontend

icatalina
icatalina approved these changes Feb 26, 2018
View reviewed changes
Copy link

@icatalina icatalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidchin davidchin merged commit 494b16a into bigcommerce:master Feb 26, 2018
@davidchin davidchin deleted the move_src branch February 26, 2018 04:11
davidchin added a commit that referenced this pull request Feb 26, 2018
@davidchin
Merge pull request #1 from davidchin/move_src
b97b90f 
CHECKOUT-2739: Move `ScriptLoader` source files into separate repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icatalina icatalina icatalina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidchin @icatalina