Manage log directory #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bfraser this pull request looks like it would also solve my problem. Pretty please? :) |
|
This is definitevely a must have but I think this patch requires more changes to manage the default init configuration, see for example the Debian default configuration: This implies also to manage the user/group accordingly to set the right on log_dir. A good example would be the Elasticsearch puppet module: https://github.com/elastic/puppet-elasticsearch/blob/master/manifests/instance.pp#L391 |
bastelfreak
pushed a commit
to bastelfreak/puppet-grafana
that referenced
this pull request
Mar 10, 2017
Fix grafana_dashboards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log directory should be managed regardless of $install_method.