Module breaks with puppet 4.4

[dalesit]

Generates the following error after upgrading to 4.4:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Resource Statement, default expression for $archive_source tries to illegally access not yet evaluated $version

This appears to be because the default definition of
$archive_source = "https://grafanarel.s3.amazonaws.com/builds/grafana-${version}.linux-x64.tar.gz"
utilises the expression
$version = $::grafana::params::version

The behaviour of this changes in 4.4 as detailed in https://github.com/puppetlabs/puppet-specifications/blob/master/language/parameter_scope.md

Workaround

Specify $version in calling manifest
If using a RedHat/Amazon os family, you also need to specify $rpm_iteration in the calling manifest

[dalesit]

Is this related to #67 and would it be fixed by #68 ?

[nickchappell]

I hit this bug too.

[caskolkm]

After you set $version in the calling manifest, you also need to set rpm_iteration..

[dalesit]

Seems logical if you are using a system with rpms (I'm on the Debian os family, so didn't hit this). I've added to the workaround text in the issue description above.

[ltutar]

I also do not hit this on CentOS when I have the following yaml

grafana::version: '2.6.0'
grafana::install_dir: '/opt/grafana'
grafana::data_dir: '/opt/grafana/data'
grafana::manage_package_repo: false
grafana::install_method: 'archive'
grafana::install_directory: '/opt/grafana'
grafana::archive_source: 'file:///tmp/grafana-2.6.0.linux-x64.tar.gz'

[bfraser]

I believe this has been fixed in acc8075 by moving the version logic to the install manifest.

[walterheck]

Fixed indeed.