Add multi-platform support for Linux ARM64, macOS Intel, and macOS Apple Silicon. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR @saidatom 🎉 |
bfabio
reviewed
Oct 31, 2025
bfabio
reviewed
Oct 31, 2025
Contributor
Author
|
@bfabio all suggestions addressed; ready for review |
bfabio
reviewed
Nov 1, 2025
.github/workflows/test.yml
Outdated
| - os: ubuntu-latest | ||
| platform: linux-arm64 | ||
| php-version: "8.3" | ||
| run-tests: false |
Owner
There was a problem hiding this comment.
We won't run tests for linux-arm64 this way. I suppose you implemented this because ubuntu-latest is x64, but actually GitHub has ubuntu-24.04-arm we can use.
I'd also use ubuntu-24.04 for x64 so both versions are uniform. Then we can remove the run-tests: logic from this file (and also the cross compilation).
Makefile
Outdated
| @echo "Built $(LIBRARY)" | ||
|
|
||
| # Build all platform variants | ||
| build-all: build-linux-amd64 build-linux-arm64 build-darwin-amd64 build-darwin-arm64 |
Owner
There was a problem hiding this comment.
Suggested change
| build-all: build-linux-amd64 build-linux-arm64 build-darwin-amd64 build-darwin-arm64 | |
| build-all: build-linux-amd64 build-linux-arm64 build-darwin-arm64 |
Makefile
Outdated
Comment on lines
19
to
21
| # Legacy symlink for backward compatibility | ||
| LEGACY_LIBRARY=$(LIB_DIR)/$(LIBRARY_NAME).so | ||
|
|
bfabio
reviewed
Nov 2, 2025
bfabio
reviewed
Nov 2, 2025
Owner
|
@saidatom great work, thanks! |
Contributor
Author
|
@bfabio Thanks! Are you planning to release a new version? |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23