Add illuminate/contracts dependency

[X-Coder264]

The illuminate/contracts dependency was missing in composer.json and I refactored some config calls to make the dependency more obvious.

[jstoone]

For me personally I like the added typehinting, but as far as I remember all of the required illuminate/* packages have a direct dependency on illuminate/contracts themselves.

I'm not sure what the "best practises" are for this, but I think it's alright to rely on their dependency of illuminate/contracts.

[jstoone]

Suggested change

"illuminate/contracts": "5.7.*",

[X-Coder264]

I'm not sure what the "best practises" are for this, but I think it's alright to rely on their dependency of illuminate/contracts.

We should not care about other packages dependencies. Each package should declare what dependencies it relies upon. If the dependencies this package depends upon suddenly drop their dependency on illuminate/contracts (which has a really low probability but still...) this package would also break which of course shouldn't happen.

[jstoone]

That does make sense. Thank you for taking the time to clarify. ✌️

[freekmurze]

Thanks for your work on this but I'm gonna pass. I think using config() is just fine in this context.

[X-Coder264]

@freekmurze Hm, I disagree. First, this PR is more about adding the illuminate/contracts dependency. Second, the config helper (and all other global helpers like app) are in the Foundation namespace which isn't there unless you require the entire laravel/framework package (which this package doesn't so using it is not "fine"). In order to lessen the coupling to the entire framework the solution is to use either the facades as they are in the illuminate/support package that this package already depends on or to just use dependency injection using the contracts provided by illuminate/contracts.