This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Update ChannelManager #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch ChannelManager to an interface. Extend with an ArrayChannelManager (and copy the code). Update the config to allow for swapping. Bind it to the ServiceProvider
Contributor
Author
I have added a fallback to the ArrayChannelManager, so there should be no change required for anyone. |
freekmurze
reviewed
Dec 10, 2018
| ], | ||
|
|
||
| /* | ||
| * Channel Manager |
Contributor
There was a problem hiding this comment.
Add some more info here on what this does and in which cases you would change this option
Contributor
Author
There was a problem hiding this comment.
Updated.
* This class handles how channel persistence is handled.
* By default, persistence is stored in an array by the running webserver.
* The only requirement is that the class should implement
* `ChannelManager` interface provided by this package.
freekmurze
approved these changes
Dec 10, 2018
Member
|
Looks good. Thank you for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #6. The idea will eventually be to create additional channel managers. A good first start is allowing the user to swap the channel manager.
This commit:
By turning ChannelManager into an interface, we keep compatibility with type hints everywhere else.
My only concern is adding something new the config, which people wouldn't have if they've already published it. Maybe I should fallback? Not sure what the best step forward is.
All the tests currently pass, but happy to add more tests if we'd like something specific tested. I'll be adding tests once I dig into implementing a new RedisChannelManager in a separate PR