fixed bevy_scene tests

Trashtalk217 · Trashtalk217 · commit f4e2b3590ab4 · 2025-07-10T20:59:12.000Z
diff --git a/crates/bevy_app/src/app.rs b/crates/bevy_app/src/app.rs
@@ -1488,7 +1488,7 @@ mod tests {
         event::{BufferedEvent, Event, EventWriter, Events},
         lifecycle::RemovedComponents,
         query::With,
-        resource::{IsResource, Resource},
+        resource::Resource,
         schedule::{IntoScheduleConfigs, ScheduleLabel},
         system::{Commands, Query},
         world::{FromWorld, World},
diff --git a/crates/bevy_ecs/src/resource.rs b/crates/bevy_ecs/src/resource.rs
@@ -1,6 +1,9 @@
 //! Resources are unique, singleton-like data types that can be accessed from systems and stored in the [`World`](crate::world::World).
 
 use crate::prelude::Component;
+use crate::prelude::ReflectComponent;
+use bevy_reflect::prelude::ReflectDefault;
+use bevy_reflect::Reflect;
 // The derive macro for the `Resource` trait
 pub use bevy_ecs_macros::Resource;
 use core::marker::PhantomData;
@@ -88,7 +91,8 @@ pub trait Resource: Send + Sync + 'static {}
 /// adding this component to an entity (or spawning an entity with this component) will despawn any other entity with this component.
 #[derive(Component, Debug)]
 #[require(IsResource)]
-pub struct ResourceEntity<R: Resource>(PhantomData<R>);
+#[cfg_attr(feature = "bevy_reflect", derive(Reflect), reflect(Component, Default))]
+pub struct ResourceEntity<R: Resource>(#[reflect(ignore)] PhantomData<R>);
 
 impl<R: Resource> Default for ResourceEntity<R> {
     fn default() -> Self {
@@ -100,6 +104,11 @@ impl<R: Resource> Default for ResourceEntity<R> {
 ///
 /// By contrast, the [`ResourceEntity<R>`] component is used to find the entity that stores a particular resource.
 /// This component is required by the [`ResourceEntity<R>`] component, and will automatically be added.
+#[cfg_attr(
+    feature = "bevy_reflect",
+    derive(Reflect),
+    reflect(Component, Default, Debug)
+)]
 #[derive(Component, Default, Debug)]
 pub struct IsResource;
 
diff --git a/crates/bevy_scene/src/lib.rs b/crates/bevy_scene/src/lib.rs
@@ -49,7 +49,13 @@ pub mod prelude {
 use bevy_app::prelude::*;
 
 #[cfg(feature = "serialize")]
-use {bevy_asset::AssetApp, bevy_ecs::schedule::IntoScheduleConfigs};
+use {
+    bevy_asset::AssetApp,
+    bevy_ecs::schedule::IntoScheduleConfigs,
+    bevy_ecs::{
+        entity_disabling::DefaultQueryFilters, resource::IsResource, resource::ResourceEntity,
+    },
+};
 
 /// Plugin that provides scene functionality to an [`App`].
 #[derive(Default)]
@@ -64,6 +70,8 @@ impl Plugin for ScenePlugin {
             .init_resource::<SceneSpawner>()
             .register_type::<SceneRoot>()
             .register_type::<DynamicSceneRoot>()
+            .register_type::<IsResource>()
+            .register_type::<ResourceEntity<DefaultQueryFilters>>()
             .add_systems(SpawnScene, (scene_spawner, scene_spawner_system).chain());
 
         // Register component hooks for DynamicSceneRoot
diff --git a/crates/bevy_scene/src/scene_spawner.rs b/crates/bevy_scene/src/scene_spawner.rs
@@ -609,7 +609,7 @@ mod tests {
         assert_eq!(scene_component_a.y, 4.0);
         assert_eq!(
             app.world().entity(entity).get::<Children>().unwrap().len(),
-            1
+            3 // two resources-as-entities are also counted
         );
 
         // let's try to delete the scene
diff --git a/crates/bevy_scene/src/serde.rs b/crates/bevy_scene/src/serde.rs
@@ -516,9 +516,11 @@ mod tests {
     };
     use bevy_ecs::{
         entity::{Entity, EntityHashMap},
+        entity_disabling::DefaultQueryFilters,
         prelude::{Component, ReflectComponent, ReflectResource, Resource, World},
         query::{With, Without},
         reflect::AppTypeRegistry,
+        resource::{IsResource, ResourceEntity},
         world::FromWorld,
     };
     use bevy_reflect::{Reflect, ReflectDeserialize, ReflectSerialize};
@@ -611,6 +613,8 @@ mod tests {
             registry.register::<MyEntityRef>();
             registry.register::<Entity>();
             registry.register::<MyResource>();
+            registry.register::<IsResource>();
+            registry.register::<ResourceEntity<DefaultQueryFilters>>();
         }
         world.insert_resource(registry);
         world
@@ -638,20 +642,20 @@ mod tests {
     ),
   },
   entities: {
-    4294967293: (
+    4294967291: (
       components: {
         "bevy_scene::serde::tests::Bar": (345),
         "bevy_scene::serde::tests::Baz": (789),
         "bevy_scene::serde::tests::Foo": (123),
       },
     ),
-    4294967294: (
+    4294967292: (
       components: {
         "bevy_scene::serde::tests::Bar": (345),
         "bevy_scene::serde::tests::Foo": (123),
       },
     ),
-    4294967295: (
+    4294967293: (
       components: {
         "bevy_scene::serde::tests::Foo": (123),
       },
@@ -757,7 +761,7 @@ mod tests {
             .write_to_world(&mut dst_world, &mut map)
             .unwrap();
 
-        assert_eq!(2, deserialized_scene.entities.len());
+        assert_eq!(4, deserialized_scene.entities.len());
         assert_scene_eq(&scene, &deserialized_scene);
 
         let bar_to_foo = dst_world
@@ -785,7 +789,7 @@ mod tests {
 
         let (scene, deserialized_scene) = roundtrip_ron(&world);
 
-        assert_eq!(1, deserialized_scene.entities.len());
+        assert_eq!(3, deserialized_scene.entities.len());
         assert_scene_eq(&scene, &deserialized_scene);
 
         let mut world = create_world();
@@ -815,10 +819,19 @@ mod tests {
 
         assert_eq!(
             vec![
-                0, 1, 255, 255, 255, 255, 15, 1, 37, 98, 101, 118, 121, 95, 115, 99, 101, 110, 101,
+                0, 3, 253, 255, 255, 255, 15, 1, 37, 98, 101, 118, 121, 95, 115, 99, 101, 110, 101,
                 58, 58, 115, 101, 114, 100, 101, 58, 58, 116, 101, 115, 116, 115, 58, 58, 77, 121,
                 67, 111, 109, 112, 111, 110, 101, 110, 116, 1, 2, 3, 102, 102, 166, 63, 205, 204,
-                108, 64, 1, 12, 72, 101, 108, 108, 111, 32, 87, 111, 114, 108, 100, 33
+                108, 64, 1, 12, 72, 101, 108, 108, 111, 32, 87, 111, 114, 108, 100, 33, 254, 255,
+                255, 255, 15, 1, 30, 98, 101, 118, 121, 95, 101, 99, 115, 58, 58, 114, 101, 115,
+                111, 117, 114, 99, 101, 58, 58, 73, 115, 82, 101, 115, 111, 117, 114, 99, 101, 255,
+                255, 255, 255, 15, 2, 30, 98, 101, 118, 121, 95, 101, 99, 115, 58, 58, 114, 101,
+                115, 111, 117, 114, 99, 101, 58, 58, 73, 115, 82, 101, 115, 111, 117, 114, 99, 101,
+                83, 98, 101, 118, 121, 95, 101, 99, 115, 58, 58, 114, 101, 115, 111, 117, 114, 99,
+                101, 58, 58, 82, 101, 115, 111, 117, 114, 99, 101, 69, 110, 116, 105, 116, 121, 60,
+                98, 101, 118, 121, 95, 101, 99, 115, 58, 58, 101, 110, 116, 105, 116, 121, 95, 100,
+                105, 115, 97, 98, 108, 105, 110, 103, 58, 58, 68, 101, 102, 97, 117, 108, 116, 81,
+                117, 101, 114, 121, 70, 105, 108, 116, 101, 114, 115, 62
             ],
             serialized_scene
         );
@@ -830,7 +843,7 @@ mod tests {
             .deserialize(&mut postcard::Deserializer::from_bytes(&serialized_scene))
             .unwrap();
 
-        assert_eq!(1, deserialized_scene.entities.len());
+        assert_eq!(3, deserialized_scene.entities.len());
         assert_scene_eq(&scene, &deserialized_scene);
     }
 
@@ -856,11 +869,21 @@ mod tests {
 
         assert_eq!(
             vec![
-                146, 128, 129, 206, 255, 255, 255, 255, 145, 129, 217, 37, 98, 101, 118, 121, 95,
+                146, 128, 131, 206, 255, 255, 255, 253, 145, 129, 217, 37, 98, 101, 118, 121, 95,
                 115, 99, 101, 110, 101, 58, 58, 115, 101, 114, 100, 101, 58, 58, 116, 101, 115,
                 116, 115, 58, 58, 77, 121, 67, 111, 109, 112, 111, 110, 101, 110, 116, 147, 147, 1,
                 2, 3, 146, 202, 63, 166, 102, 102, 202, 64, 108, 204, 205, 129, 165, 84, 117, 112,
-                108, 101, 172, 72, 101, 108, 108, 111, 32, 87, 111, 114, 108, 100, 33
+                108, 101, 172, 72, 101, 108, 108, 111, 32, 87, 111, 114, 108, 100, 33, 206, 255,
+                255, 255, 254, 145, 129, 190, 98, 101, 118, 121, 95, 101, 99, 115, 58, 58, 114,
+                101, 115, 111, 117, 114, 99, 101, 58, 58, 73, 115, 82, 101, 115, 111, 117, 114, 99,
+                101, 144, 206, 255, 255, 255, 255, 145, 130, 190, 98, 101, 118, 121, 95, 101, 99,
+                115, 58, 58, 114, 101, 115, 111, 117, 114, 99, 101, 58, 58, 73, 115, 82, 101, 115,
+                111, 117, 114, 99, 101, 144, 217, 83, 98, 101, 118, 121, 95, 101, 99, 115, 58, 58,
+                114, 101, 115, 111, 117, 114, 99, 101, 58, 58, 82, 101, 115, 111, 117, 114, 99,
+                101, 69, 110, 116, 105, 116, 121, 60, 98, 101, 118, 121, 95, 101, 99, 115, 58, 58,
+                101, 110, 116, 105, 116, 121, 95, 100, 105, 115, 97, 98, 108, 105, 110, 103, 58,
+                58, 68, 101, 102, 97, 117, 108, 116, 81, 117, 101, 114, 121, 70, 105, 108, 116,
+                101, 114, 115, 62, 144
             ],
             buf
         );
@@ -874,7 +897,7 @@ mod tests {
             .deserialize(&mut rmp_serde::Deserializer::new(&mut reader))
             .unwrap();
 
-        assert_eq!(1, deserialized_scene.entities.len());
+        assert_eq!(3, deserialized_scene.entities.len());
         assert_scene_eq(&scene, &deserialized_scene);
     }
 
@@ -899,13 +922,23 @@ mod tests {
 
         assert_eq!(
             vec![
-                0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 255, 255, 255, 255, 0, 0, 0, 0, 1,
+                0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 253, 255, 255, 255, 0, 0, 0, 0, 1,
                 0, 0, 0, 0, 0, 0, 0, 37, 0, 0, 0, 0, 0, 0, 0, 98, 101, 118, 121, 95, 115, 99, 101,
                 110, 101, 58, 58, 115, 101, 114, 100, 101, 58, 58, 116, 101, 115, 116, 115, 58, 58,
                 77, 121, 67, 111, 109, 112, 111, 110, 101, 110, 116, 1, 0, 0, 0, 0, 0, 0, 0, 2, 0,
                 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 102, 102, 166, 63, 205, 204, 108, 64, 1,
                 0, 0, 0, 12, 0, 0, 0, 0, 0, 0, 0, 72, 101, 108, 108, 111, 32, 87, 111, 114, 108,
-                100, 33
+                100, 33, 254, 255, 255, 255, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 30, 0, 0, 0, 0, 0,
+                0, 0, 98, 101, 118, 121, 95, 101, 99, 115, 58, 58, 114, 101, 115, 111, 117, 114,
+                99, 101, 58, 58, 73, 115, 82, 101, 115, 111, 117, 114, 99, 101, 255, 255, 255, 255,
+                0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 30, 0, 0, 0, 0, 0, 0, 0, 98, 101, 118, 121, 95,
+                101, 99, 115, 58, 58, 114, 101, 115, 111, 117, 114, 99, 101, 58, 58, 73, 115, 82,
+                101, 115, 111, 117, 114, 99, 101, 83, 0, 0, 0, 0, 0, 0, 0, 98, 101, 118, 121, 95,
+                101, 99, 115, 58, 58, 114, 101, 115, 111, 117, 114, 99, 101, 58, 58, 82, 101, 115,
+                111, 117, 114, 99, 101, 69, 110, 116, 105, 116, 121, 60, 98, 101, 118, 121, 95,
+                101, 99, 115, 58, 58, 101, 110, 116, 105, 116, 121, 95, 100, 105, 115, 97, 98, 108,
+                105, 110, 103, 58, 58, 68, 101, 102, 97, 117, 108, 116, 81, 117, 101, 114, 121, 70,
+                105, 108, 116, 101, 114, 115, 62
             ],
             serialized_scene
         );
@@ -918,7 +951,7 @@ mod tests {
             bincode::serde::seed_decode_from_slice(scene_deserializer, &serialized_scene, config)
                 .unwrap();
 
-        assert_eq!(1, deserialized_scene.entities.len());
+        assert_eq!(3, deserialized_scene.entities.len());
         assert_scene_eq(&scene, &deserialized_scene);
     }
 
