Skip to content

Commit 9191880

Browse files
committed
Mention search filters in CONTRIBUTING.md (#6804)
* Adding a new section concerning the maintainers of the repo # Objective - Adding a few helpful links in the CONTRIBUTING.md files - Fixes #6221 ## Solution - Modifying CONTRIBUTING.md - Adding a new section dedicated to maintainers in CONTRIBUTING.md --- Co-authored-by: Ptipiak <[email protected]>
1 parent c7d2cb1 commit 9191880

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

CONTRIBUTING.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,10 +262,11 @@ When in doubt about a matter of architectural philosophy, refer back to [*What w
262262
Once you're happy with the work and feel you're reasonably qualified to assess quality in this particular area, leave your `Approved` review on the PR.
263263
If you're new to GitHub, check out the [Pull Request Review documentation](https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews). Anyone can leave reviews ... no special permissions are required!
264264

265-
There are a two main places you can check for things to review:
265+
There are three main places you can check for things to review:
266266

267-
1. Pull requests on [bevy](https://github.com/bevyengine/bevy/pulls) and the [bevy-website](https://github.com/bevyengine/bevy-website/pulls) repos.
268-
2. [RFCs](https://github.com/bevyengine/rfcs), which need extensive thoughtful community input on their design.
267+
1. Pull request which are ready and in need of more reviews on [bevy](https://github.com/bevyengine/bevy/pulls?q=is%3Aopen+is%3Apr+-label%3AS-Ready-For-Final-Review+-draft%3A%3Atrue+-label%3AS-Needs-RFC+-reviewed-by%3A%40me+-author%3A%40me)
268+
2. Pull requests on [bevy](https://github.com/bevyengine/bevy/pulls) and the [bevy-website](https://github.com/bevyengine/bevy-website/pulls) repos.
269+
3. [RFCs](https://github.com/bevyengine/rfcs), which need extensive thoughtful community input on their design.
269270

270271
Official focus areas and work done by @cart go through this review process as well.
271272
Not even our project lead is exempt from reviews and RFCs!
@@ -274,6 +275,15 @@ By giving feedback on this work (and related supporting work), you can help us m
274275
Finally, if nothing brings you more satisfaction than seeing every last issue labeled and all resolved issues closed, feel free to message @cart for a Bevy org role to help us keep things tidy.
275276
As discussed in [*How we're organized*](#how-were-organized), this role only requires good faith and a basic understanding of our development process.
276277

278+
### Maintaining code
279+
280+
Maintainers can merge uncontroversial pull requests that have at least two approvals (or at least one for trivial changes).
281+
282+
These search filters show the requests that can be merged by maintainers, and those which need a final approval from @cart.
283+
284+
1. Pulls requests which are ready for maintainers to merge without consultation: [requests to pull](https://github.com/bevyengine/bevy/pulls?q=is%3Aopen+is%3Apr+label%3AS-Ready-For-Final-Review+-label%3AS-Controversial+-label%3AS-Blocked+-label%3AS-Adopt-Me+)
285+
2. Pull requests which need final input from @cart: [requests to verify](https://github.com/bevyengine/bevy/pulls?q=is%3Aopen+is%3Apr+label%3AS-Ready-For-Final-Review+label%3AS-Controversial+)
286+
277287
### Contributing code
278288

279289
Bevy is actively open to code contributions from community members.

0 commit comments

Comments
 (0)