Skip to content

Commit 6c86545

Browse files
Fix Plane UVs / texture flip (#8878)
# Objective Fix #1018 (Textures on the `Plane` shape appear flipped). This bug have been around for a very long time apparently, I tested it was still there (see test code bellow) and sure enough, this image: ![test](https://github.com/bevyengine/bevy/assets/134181069/4cda7cf8-57d9-4677-91f5-02240d1e79b1) ... is flipped vertically when used as a texture on a plane (in main, 0.10.1 and 0.9): ![image](https://github.com/bevyengine/bevy/assets/134181069/0db4f52a-51af-4041-9c45-7bfe1f08b0cc) I'm pretty confused because this bug is so easy to fix, it has been around for so long, it is easy to encounter, and PRs touching this code still didn't fix it: #7546 To the point where I'm wondering if it's actually intended. If it is, please explain why and this PR can be changed to "mention that in the doc". ## Solution Fix the UV mapping on the Plane shape Here is how it looks after the PR ![image](https://github.com/bevyengine/bevy/assets/134181069/e07ce641-3de8-4da3-a4f3-95a6054c86d7) ## Test code ```rust use bevy::{ prelude::*, }; fn main () { App::new() .add_plugins(DefaultPlugins) .add_startup_system(setup) .run(); } fn setup( mut commands: Commands, assets: ResMut<AssetServer>, mut meshes: ResMut<Assets<Mesh>>, mut materials: ResMut<Assets<StandardMaterial>>, ) { commands.spawn(Camera3dBundle { transform: Transform::from_xyz(0., 3., 0.).looking_at(Vec3::ZERO, Vec3::NEG_Z), ..default() }); let mesh = meshes.add(Mesh::from(shape::Plane::default())); let texture_image = assets.load("test.png"); let material = materials.add(StandardMaterial { base_color_texture: Some(texture_image), ..default() }); commands.spawn(PbrBundle { mesh, material, ..default() }); } ``` ## Changelog Fix textures on `Plane` shapes being flipped vertically. ## Migration Guide Flip the textures you use on `Plane` shapes.
1 parent 17e1d21 commit 6c86545

File tree

1 file changed

+4
-4
lines changed
  • crates/bevy_render/src/mesh/shape

1 file changed

+4
-4
lines changed

crates/bevy_render/src/mesh/shape/mod.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -233,13 +233,13 @@ impl From<Plane> for Mesh {
233233
let mut uvs: Vec<[f32; 2]> = Vec::with_capacity(num_vertices);
234234
let mut indices: Vec<u32> = Vec::with_capacity(num_indices);
235235

236-
for y in 0..z_vertex_count {
236+
for z in 0..z_vertex_count {
237237
for x in 0..x_vertex_count {
238238
let tx = x as f32 / (x_vertex_count - 1) as f32;
239-
let ty = y as f32 / (z_vertex_count - 1) as f32;
240-
positions.push([(-0.5 + tx) * plane.size, 0.0, (-0.5 + ty) * plane.size]);
239+
let tz = z as f32 / (z_vertex_count - 1) as f32;
240+
positions.push([(-0.5 + tx) * plane.size, 0.0, (-0.5 + tz) * plane.size]);
241241
normals.push(up);
242-
uvs.push([tx, 1.0 - ty]);
242+
uvs.push([tx, tz]);
243243
}
244244
}
245245

0 commit comments

Comments
 (0)