Prefer reflect_type_info for dyn Reflect values

Author: MrGVSV

crates/bevy_reflect/src/lib.rs

@@ -1614,7 +1614,7 @@ mod tests {
 
         // TypeInfo (instance)
         let value: &dyn Reflect = &123_i32;
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<i32>());
 
         // Struct
@@ -1635,7 +1635,7 @@ mod tests {
         assert_eq!(usize::type_path(), info.field_at(1).unwrap().type_path());
 
         let value: &dyn Reflect = &MyStruct { foo: 123, bar: 321 };
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyStruct>());
 
         // Struct (generic)
@@ -1657,7 +1657,7 @@ mod tests {
             foo: String::from("Hello!"),
             bar: 321,
         };
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyGenericStruct<String>>());
 
         // Struct (dynamic field)
@@ -1687,7 +1687,7 @@ mod tests {
             foo: DynamicStruct::default(),
             bar: 321,
         };
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyDynamicStruct>());
 
         // Tuple Struct
@@ -1713,7 +1713,7 @@ mod tests {
         assert!(info.field_at(1).unwrap().type_info().unwrap().is::<f32>());
 
         let value: &dyn Reflect = &(123_u32, 1.23_f32, String::from("Hello!"));
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyTuple>());
 
         // List
@@ -1728,7 +1728,7 @@ mod tests {
         assert_eq!(usize::type_path(), info.item_ty().path());
 
         let value: &dyn Reflect = &vec![123_usize];
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyList>());
 
         // List (SmallVec)
@@ -1745,7 +1745,7 @@ mod tests {
 
             let value: MySmallVec = smallvec::smallvec![String::default(); 2];
             let value: &dyn Reflect = &value;
-            let info = value.get_represented_type_info().unwrap();
+            let info = value.reflect_type_info();
             assert!(info.is::<MySmallVec>());
         }
 
@@ -1761,7 +1761,7 @@ mod tests {
         assert_eq!(3, info.capacity());
 
         let value: &dyn Reflect = &[1usize, 2usize, 3usize];
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyArray>());
 
         // Cow<'static, str>
@@ -1773,7 +1773,7 @@ mod tests {
         assert_eq!(std::any::type_name::<MyCowStr>(), info.type_path());
 
         let value: &dyn Reflect = &Cow::<'static, str>::Owned("Hello!".to_string());
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyCowStr>());
 
         // Cow<'static, [u8]>
@@ -1788,7 +1788,7 @@ mod tests {
         assert_eq!(std::any::type_name::<u8>(), info.item_ty().path());
 
         let value: &dyn Reflect = &Cow::<'static, [u8]>::Owned(vec![0, 1, 2, 3]);
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyCowSlice>());
 
         // Map
@@ -1806,7 +1806,7 @@ mod tests {
         assert_eq!(f32::type_path(), info.value_ty().path());
 
         let value: &dyn Reflect = &MyMap::new();
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyMap>());
 
         // Value
@@ -1818,7 +1818,7 @@ mod tests {
         assert_eq!(MyValue::type_path(), info.type_path());
 
         let value: &dyn Reflect = &String::from("Hello!");
-        let info = value.get_represented_type_info().unwrap();
+        let info = value.reflect_type_info();
         assert!(info.is::<MyValue>());
     }
 

crates/bevy_reflect/src/serde/ser.rs

@@ -38,12 +38,8 @@ fn get_serializable<'a, E: Error>(
             reflect_value.reflect_type_path()
         )));
     };
-    let info = reflect_value.get_represented_type_info().ok_or_else(|| {
-        Error::custom(format_args!(
-            "Type '{}' does not represent any type",
-            reflect_value.reflect_type_path(),
-        ))
-    })?;
+
+    let info = reflect_value.reflect_type_info();
 
     let registration = type_registry.get(info.type_id()).ok_or_else(|| {
         Error::custom(format_args!(

examples/reflection/type_data.rs

@@ -80,7 +80,7 @@ fn main() {
     registry.register_type_data::<Zombie, ReflectDamageable>();
 
     // Then at any point we can retrieve the type data from the registry:
-    let type_id = value.get_represented_type_info().unwrap().type_id();
+    let type_id = value.reflect_type_info().type_id();
     let reflect_damageable = registry
         .get_type_data::<ReflectDamageable>(type_id)
         .unwrap();
@@ -133,7 +133,7 @@ fn main() {
     // Now we can use `ReflectHealth` to convert `dyn Reflect` into `dyn Health`:
     let value: Box<dyn Reflect> = Box::new(Skeleton { health: 50 });
 
-    let type_id = value.get_represented_type_info().unwrap().type_id();
+    let type_id = value.reflect_type_info().type_id();
     let reflect_health = registry.get_type_data::<ReflectHealth>(type_id).unwrap();
 
     // Type data generated by `#[reflect_trait]` comes with a `get`, `get_mut`, and `get_boxed` method,