Add typings for Pipe API #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjamine is there a version bump planned soon which you might be able to include this fix in? It would be great to remove some hacky workarounds for this and #236. Thanks! |
|
@ian-craig thanks, sorry for the delays, I'm catching up with open issues (new year resolution? :) ), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
I've also included some minor bug fixes to other parts of the typings such as
objectHashand the constructor options.I'm not including all functions/props on the classes in your JS files, because I'm not sure which should be exposed publicly and which are intended to be internal helpers. So, I've included everything which I can find referenced in docs, and tried to pull the doc strings from those same docs.