fix: Fix optional model properties BNCH-20284 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forest-benchling
changed the title
bowenwr
approved these changes
Jan 21, 2021
bowenwr
left a comment
bowenwr
left a comment
There was a problem hiding this comment.
LGTM. If you're regenerating the client to test, you'll want to merge this into the benchling-sdk-m1-fixes branch on openapi-specs and integration test the whole client to make sure there are no regressions. Let me know if you need help with that.
forest-benchling
changed the base branch from
benchling-issue-285
to
main-v.0.7.3
Author
|
Ugh, messed up the merge |
forest-benchling
force-pushed
the
forest-model-property
branch
from
d5073d9 to
2ad8d29
Compare
bowenwr
pushed a commit
that referenced
this pull request
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the case when a model property is
nullable, and adds E2E test coverage for this case.I'm going to upstream this, but was planning to wait until openapi-generators#297 is merged (and didn't want to lump it into that PR to avoid scope creep).
Going to test by pulling this change into the
benchling-sdkand confirming that integration tests pass (in particular for theContainerandLocationservices).Upstream PR: openapi-generators#315