chore: Ran gen-setuppy to update openapi setup.py BNCH-42828 #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwr
approved these changes
May 18, 2022
bowenwr
left a comment
bowenwr
left a comment
There was a problem hiding this comment.
Asked for a comment in TOML, non-blocking
| [tool.poetry] | ||
| name = "openapi-python-client" | ||
| version = "0.7.3" | ||
| version = "1.0.0" |
There was a problem hiding this comment.
We should add a comment that our versions have diverged and are maintained internally with no relation to the upstream.
Author
There was a problem hiding this comment.
Added a small note in regards to version divergence :)
Author
There was a problem hiding this comment.
Added sed statement to rename package on setup.py and also updated README to identify the change and needing to install/download GNU sed instead of BSD sed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildkite pipeline on deployment can be found here
The idea is to run
poetry run task gen-setuppyto update setup.py which Aurelia uses to build and package the project for publishing.Updated and ran unit test(s) to pass as well
NOTE: gen-setuppy has been updated to change the package name on setup.py to be
benchling-openapi-python-clientFollow the README to download/install/use the correct version of
sedi.e. GNU sed instead of BSD sed