fix: Upgraded Jinja2 version to 3.x.x CEPLAT-477 #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaw-matt
suggested changes
Apr 5, 2022
There was a problem hiding this comment.
Changes looks good, but I think the end-to-end tests should be run as well as a local functional test to make sure that the dependency problems/unnecessary pinning Jinja is causing are fixed with this change.
Also, it looks like a bot already created a PR for this, so might be useful to compare the changes and then delete which ever PR doesn't end up getting merged
shaw-matt
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
poetry run task e2eand threw this error:Ran
poetry run task unitand passed all but 1 testI've checked out older versions to see if it was an issue that this ticket introduced but that was not the case. The branch that I'm looking to merge into tha benchling-sdk is currently pointing to, throws the same error(s).
Tried to make some slight changes to see if I could fix it, but I think it'll require more dependency changes that is out of scope for this ticket.
Also do note that I'm running it on 3.7.13 since i can't go down to 3.7.4 (I did pair with someone that had 3.7.4 installed and had the same error)