Skip to content

fixed for stuff found by mypy #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2023
Merged

fixed for stuff found by mypy #57

merged 1 commit into from
Nov 26, 2023

Conversation

@igorbenav
Copy link
Collaborator

@igorbenav igorbenav commented Nov 26, 2023

Summary

Bugs fixed and now working with MyPy.

🚀Features

  • mypy settings created

🔎Bug fixes

  • removed uuid_pkg.UUID(as_uuid=True) from uuid mixin
  • status_code.description changed to HTTPStatus(status_code).description in custom exception definition
  • bound base added: ModelType = TypeVar("ModelType", bound=Base)
  • PostUpdate inheriting from BaseModel instead of PostBase
  • MissingClientError created plus a bunch of None dealt with
  • fixed some type hints, also docs

@igorbenav igorbenav added bug Something isn't working enhancement New feature or request labels Nov 26, 2023
@igorbenav igorbenav self-assigned this Nov 26, 2023
@igorbenav igorbenav merged commit d8ab798 into main Nov 26, 2023
@igorbenav igorbenav deleted the mypy-fixes branch November 26, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@igorbenav igorbenav

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@igorbenav