Performance issue when running CLI in project with pnpm on Windows

[Methuselah96]

Environments:

• CSharpier Version: 1.2.3
• Running CSharpier via: dotnet cli
• Operating System: Windows
• .csharpierrc Settings: N/A
• .editorconfig Settings: N/A

Steps to reproduce:

Run dotnet csharpier format . on Windows in a project that uses pnpm with a large number of packages.

Expected behavior:

Formats in a reasonable amount of time

Actual behavior:

Takes about 5 minutes to run formatting.

I've narrowed the issue down to the call to .EnumerateFiles() in HasMismatchedCliAndMsBuildVersions.Check(). Running CSharpier with the --no-msbuild-check gets rid of the performance issue, and runs in 2-3 seconds instead of 5 minutes, but it'd be nice to not have to pass that flag when using the tool.

[belav]

I've been debating how useful that check even is, I'll see if I can figure out what it is doing that is causing the problems and possibly remove it completely.

[Methuselah96]

Yeah, I think it's just the Windows file system being slow, especially when traversing the node_modules with a lot of symlinks (or the Windows alternative to symlinks). I believe it was even slower before #1778, so calling EnumerateNonignoredFiles instead of .EnumerateFiles() so that it skips node_modules may be one way to fix it.

[belav]

My testing of EnumerateNonignoredFiles showed that it was quite a bit slower than EnumerateFiles for my fairly large work repo that has a few node_modules folders. I went with a modified version of EnumerateNonignoredFiles that just skips over node_modules and .git. It was a little slower for my work project but I imagine it will be significantly faster for your project setup. Let me know if you are still having issues, I'll try to get 1.2.4 out tonight.