Skip to content

Conversation

freakboy3742
Copy link
Member

Refs #50.
Fixes #49.

This is the code contributed by @johnzhou721, but with some additional consistency tweaks; as the PR for #50 was created from a main branch, it wasn't possible to commit directly to that branch.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 mentioned this pull request Apr 14, 2025
1 task
@johnzhou721
Copy link
Contributor

Why can’t you push to main? Some bizarre git issue? Just curious and thanks for helping me clean this up

@freakboy3742
Copy link
Member Author

Why can’t you push to main? Some bizarre git issue? Just curious and thanks for helping me clean this up

Because it's your main.

A PR, by definition, is a set of proposed changes; If you've opened a PR on my repo, then it's reasonable to assume that it's OK for me to make modifications.

However, your main branch could be a branch that you're using for a specific purpose. As a result, Github doesn't give me permission to push to your main branch by default. It is possible to configure your repo to give me access... but for the sake of one PR, it's easier to just use a separate PR.

More generally - submitting pull requests from the main branch is a bad idea, because you then don't have a "clean state of the upstream" readily available. For example, when this PR is merged, you won't be able to update your main to get a clean state from which to branch off - you'll need to do some rebasing or resetting to get back to a clean state.

I have asked Github many times to provide an option to disable PRs from main because of the complications it causes for contributors, but they have consistently ignored the request.

@johnzhou721
Copy link
Contributor

Sorry. First time using GitHub fork system with git so sort of confused and thanks for the clarification!!

@johnzhou721
Copy link
Contributor

CIs are passing. Merge?

@freakboy3742 freakboy3742 merged commit 36d17e9 into main Apr 14, 2025
4 checks passed
@freakboy3742 freakboy3742 deleted the visionOS branch April 14, 2025 00:42
@johnzhou721 johnzhou721 mentioned this pull request Apr 14, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support visionOS
2 participants