-
-
Notifications
You must be signed in to change notification settings - Fork 187
Update USAGE.md for iOS and macOS #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have updated README.md to a more clear structure, and described a better way to fit the swift module requirement, instead of changing target - build settings - search path - Header Search Paths: $(BUILT_PRODUCTS_DIR)/Python.framework/Headers |
Thanks for the PR; however, I merged a fix for #234 about 5 minutes before you submitted this PR. As a result, at the very least, this PR currently contains merge conflicts. However, even allowing for that, I'm not sure I agree the rest of the changes you've made are entirely beneficial.
There's probably a case for splitting out the non PythonKit parts into a "The manual way, but with Swift" option earlier in the usage guide, and then making the PythonKit discussion just about Pythonkit. However, that's quite a way from what this PR currently has, so I'm going to close this PR and tackle that refactor as a separate update. |
@freakboy3742 happy to see you update the Usage.md in more clear structure.
|
That's not what your original comment described. Can you clarify the difference between
I understand that, and I agree that "just drop it in" would be preferable. However, the files you're proposing to move around are part of CPython. I'm happy to add a modulemap because that's a capability that doesn't exist in the official CPython sources, but it's plausible that it could be added. I'm not going to make arbitrary changes to the locations of files just to make one specific use case easier. They're in that location for a reason, and we can't arbitrarily move them without consequences. This might indicate there's a problem with CPython itself - in which case, the place to fix this is in CPython. I'm a member of the CPython core team, so I'm open to suggestions on things should be fixed, and I'm in a position to ensure those fixes are applied. In the meantime, I'm not going to deviate from what CPython is just for the convenience of this distribution project. |
@freakboy3742 This is well documented in the clang doc I also provided an update Swift Code to test Python framework without PythonKit package Next step I'll try to wrap the Python.xcframework in a Swift Package |
That explains what a framework module is, but it doesn't really explain the difference between that and a non-framework module. Also - in my testing, whether I use the framework module or the non-framework module, I get over 100 warnings raised saying "Umbrella header for module 'Python' does not include header ..." for
The best way to contribute changes is as a pull request. Pointing me at a Notion document or referring to another project is very difficult for me to determine what change you're proposing to make.
Sure - again, if there's something I can add to Python's generated framework that improves usage for Swift, I'm happy to consider those changes. Also - if you've got suggestions for additional changes, it's a lot easier to open new tickets, or continue a discussion on an open pull request, rather than commenting on a ticket that has already been closed. |
Update iOS and macOS usage for Swift and PythonKit
Solve the problem which usage.md is outdated for path settings, and how to edit Python.framework to fit Swift module requirements.
Fixs #234
PR Checklist: