Reorganize package structure and update imports to use `org.beehive.g… #42
Conversation
…pullama3` namespace for improved modularity and clarity.
…ty and structure.
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the Java package structure by migrating from the com.example namespace to the org.beehive.gpullama3 namespace for improved modularity and clarity.
- Updates all package declarations from
com.example.*toorg.beehive.gpullama3.* - Updates all corresponding import statements across the codebase
- Updates Maven configuration and shell scripts to reflect the new main class path
Reviewed Changes
Copilot reviewed 78 out of 78 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| Java source files (65 files) | Package declarations and import statements updated to use org.beehive.gpullama3 namespace |
pom.xml |
Maven groupId and main class configuration updated to new namespace |
llama-tornado |
Shell script updated to reference new main class path |
README.md |
Documentation updated with new main class path |
Comments suppressed due to low confidence (1)
|
|
||
| import static com.example.LlamaApp.USE_VECTOR_API; | ||
|
|
||
| public final class Q8_0FloatTensor extends FloatTensor { |
There was a problem hiding this comment.
The removal of the static import import static com.example.LlamaApp.USE_VECTOR_API; without replacing it with the equivalent import from the new namespace will cause compilation errors if the USE_VECTOR_API constant is used in this class.
|
|
||
| import static com.example.LlamaApp.USE_VECTOR_API; | ||
|
|
||
| public final class ArrayFloatTensor extends FloatTensor { |
There was a problem hiding this comment.
The removal of the static import import static com.example.LlamaApp.USE_VECTOR_API; without replacing it with the equivalent import from the new namespace will cause compilation errors if the USE_VECTOR_API constant is used in this class.
| import jdk.incubator.vector.VectorSpecies; | ||
| import sun.misc.Unsafe; | ||
|
|
||
| import java.lang.foreign.MemorySegment; |
There was a problem hiding this comment.
The removal of the import import java.lang.foreign.ValueLayout; may cause compilation errors if ValueLayout is used elsewhere in this class.
| import com.example.core.model.GGMLType; | ||
| import com.example.inference.weights.standard.StandardWeights; | ||
| import org.beehive.gpullama3.core.model.GGMLType; | ||
| import uk.ac.manchester.tornado.api.types.arrays.FloatArray; |
There was a problem hiding this comment.
The removal of the import import com.example.inference.weights.standard.StandardWeights; without replacing it with the equivalent import from the new namespace will cause compilation errors if the StandardWeights class is used in this file.
| package com.example.core.model; | ||
|
|
||
| import com.example.core.types.Float16; | ||
| package org.beehive.gpullama3.core.model; |
There was a problem hiding this comment.
The removal of the import import com.example.core.types.Float16; without replacing it with the equivalent import from the new namespace will cause compilation errors if the Float16 class is used in this enum.
| import com.example.core.model.tensor.GGMLTensorEntry; | ||
| import com.example.core.types.MetadataValueType; | ||
| import com.example.core.types.Pair; | ||
| import org.beehive.gpullama3.auxiliary.Timer; |
There was a problem hiding this comment.
The removal of the self-referencing import import com.example.core.model.GGUF.GGUFTensorInfo; suggests that GGUFTensorInfo is an inner class that should be referenced without import, but this change may cause issues if the import was necessary for some reason.
| import org.beehive.gpullama3.model.format.ChatFormat; | ||
| import org.beehive.gpullama3.tokenizer.impl.Phi3Tokenizer; | ||
| import org.beehive.gpullama3.tokenizer.impl.Tokenizer; | ||
| import org.beehive.gpullama3.tornadovm.TornadoVMMasterPlan; |
There was a problem hiding this comment.
The removal of the import import com.example.model.Model; without replacing it with the equivalent import from the new namespace will cause compilation errors if the Model interface is used in this class beyond what's provided by AbstractModel.
| import org.beehive.gpullama3.model.phi3.Phi3Configuration; | ||
| import org.beehive.gpullama3.tokenizer.impl.Phi3Tokenizer; | ||
| import org.beehive.gpullama3.tokenizer.impl.Tokenizer; | ||
| import org.beehive.gpullama3.tokenizer.vocabulary.Vocabulary; |
There was a problem hiding this comment.
The removal of the import import com.example.model.Model; without replacing it with the equivalent import from the new namespace will cause compilation errors if the Model interface is used in this class.
1 participant
…pullama3` namespace for improved modularity and clarity.