-
Couldn't load subscription status.
- Fork 22
Update README for clarity #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mikepapadim
commented
Jul 1, 2025
- shorter inititial description
- move Java command output further up to make it more obvious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refines the README by condensing the introduction, surfacing the --show-command integration guide earlier, and removing a redundant section at the end.
- Shortened and clarified the project summary.
- Added a dedicated “Integration with Your Java Codebase or Tools” section near the usage examples.
- Removed the duplicate integration instructions block at the bottom.
Comments suppressed due to low confidence (2)
README.md:165
- [nitpick] This sentence is quite verbose; consider simplifying for readability, e.g.: 'It prints the full Java command and JVM flags used for TornadoVM GPU execution.'
This flag shows the exact Java command with all JVM flags that are being invoked under the hood to enable seamless execution on GPUs with TornadoVM.
README.md:23
- [nitpick] The phrasing 'it can be found in' is awkward—consider 'Previous integration with TornadoVM and Llama2 can be found at ...' for better clarity.
Previous integration of TornadoVM and Llama2 it can be found in <a href="https://github.com/mikepapadim/llama2.tornadovm.java">llama2.tornadovm</a>.
|
|
||
| ## ☕ Integration with Your Java Codebase or Tools | ||
|
|
||
| To integrate it into your codebase or IDE (e.g., IntelliJ) or custom build system (like IntelliJ, Maven, or Gradle), use the `--show-command` flag. |
Copilot
AI
Jul 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] There's a duplicate mention of IntelliJ in the tool list. Consider consolidating examples to avoid repetition, e.g., 'IDE or custom build system (e.g., IntelliJ, Maven, or Gradle)'.
| To integrate it into your codebase or IDE (e.g., IntelliJ) or custom build system (like IntelliJ, Maven, or Gradle), use the `--show-command` flag. | |
| To integrate it into your codebase or IDE or custom build system (e.g., IntelliJ, Maven, or Gradle), use the `--show-command` flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codebase, or IDE, or custom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted only a full-stop to be added. LGTM
Co-authored-by: Thanos Stratikopoulos <[email protected]>