Fix setting Debug mode from IDE/command line. #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bredelings
force-pushed
the
fix-debug-mode
branch
from
3e5e1c2 to
e810c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically in cmake to compile in debug mode, you would add -DCMAKE_BUILD_TYPE=Debug to the cmake command line. In addition to the command line, various IDEs assume also add
-DCMAKE_BUILD_TYPE=Debugto create a debugable executable.Right now the CMakeLists.txt prevent this. First, it sets CMAKE_BUILD_TYPE, which overrides whatever is set on the command line. Second, it forces
-O3optimization, which makes debugging difficult.This PR addresses these problems by:
-O3optimization ifCMAKE_BUILD_TYPEis notDebug.