Skip to content

Conversation

@lukaciko
Copy link
Contributor

@lukaciko lukaciko commented Jan 17, 2023

We saw an issue related to bazelbuild/rules_android#310: files besides crashlytics-build.properties end up affecting and being pulled into outputs of resource processing actions (e.g. assets.bin). We occasionally saw failures like:

ERROR: <foo>/app/debug/crashlytics/BUILD.bazel:11:28: Merging Android assets for //<foo>/app/debug/crashlytics:crashlytics failed: Worker process did not return a WorkResponse:

---8<---8<--- Start of log, file at /private/var/tmp/_bazel_spotify-buildagent/985b781559c7830232d18af8d0be54d9/bazel-workers/worker-12-AndroidAssetMerger.log ---8<---8<---
(empty)
---8<---8<--- End of log ---8<---8<---

which went away if we changed the build_id.

This change generates an assets subfolder with the properties file and specifies that as assets_dir. This way only that single file ends up as an input to the resource processing actions.

@lukaciko lukaciko requested review from ahumesky and jin as code owners January 17, 2023 11:15
pswaminathan added a commit to pswaminathan/tools_android that referenced this pull request Oct 31, 2024
@ahumesky
Copy link
Collaborator

ahumesky commented Nov 4, 2024

thank you!

@ahumesky ahumesky merged commit b0e49ba into bazelbuild:master Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants