Skip to content

Conversation

@pswaminathan
Copy link
Contributor

Without this, using two crashlytics_android_library targets in the same package fails with:

	File "/myapp/app/BUILD.bazel", line 281, column 28, in <toplevel>
		crashlytics_android_library(
	File "/private/var/tmp/_bazel_p/c1a9d93c5d307e720ae1d0573bce325b/external/tools_android/tools/crashlytics/defs.bzl", line 11, column 17, in crashlytics_android_library
		native.genrule(
Error in genrule: generated file 'crashlytics-build.properties' in rule 'crashlytics_lib_staging_crashlytics_setup_properties' conflicts with existing generated file from rule 'crashlytics_lib_debug_crashlytics_setup_properties', defined at /myapp/app/BUILD.bazel:274:28

@pswaminathan pswaminathan requested review from ahumesky and jin as code owners May 16, 2022 17:34
@pswaminathan pswaminathan force-pushed the crashlytics-properties-filename branch from bc5a212 to 287accf Compare May 16, 2022 17:36
@ahumesky
Copy link
Collaborator

Yes this does look like a bug, thank you for taking a look at this!

I think some files here are conventionally named, like com_crashlytics_build_id.xml, so it might be better to move these into a folder with the name of the target, so how about something like

"_%s_crashlytics/crashlytics-build.properties" % name
"_%s_crashlytics/CrashlyticsManifest.xml" % name
"_%s_crashlytics/res/values/com_crashlytics_build_id.xml" % name

@pswaminathan
Copy link
Contributor Author

Good idea—changed!

@ahumesky ahumesky merged commit 7224f55 into bazelbuild:master May 16, 2022
@ahumesky
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants