Add custom_package to android_library generated by crashlytics_android_library #6
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to set up a crashlytics example using bazel firebase example as a base I discovered that it doesn't build. After following the README and updating the WORKSPACE file to a recent commit of
tools_android, it turned out that bazel fails with an errorIt fails because bazel can't determine the package from the location of the BUILD file.
This PR fixes it by explicitly setting
custom_packageon theandroid_librarycreated bycrashlytics_android_library.