Remove hyphens from UUID to satisfy mapping file ID requirements #14
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hyphens from UUID to satisfy mapping file ID requirements
I don't know if this is official or documented anywhere, but it looks
like the mapping file ID must be a UUID *without hyphens*. Uploading a
file with a UUID like 6ac7912c-d163-47a0-ae4e-f6d3ad3a21c7 results in
an API response like:
```
"error": {
"code": 3,
"message": "Invalid URL: Not a valid uuid."
}
```
Removing the hyphens makes it work.
I'm not sure how "generalizable" we want the code in this repository
to be. It seems to me that this target should specifically be used to
generate a UUID that can be used directly for a mapping file upload.
To that end, I think it is correct to follow the exact format that
makes this work, rather than make something purely generalizable.
Collaborator
|
Yeah this tool doesn't need to be generic. Could you also update the README.md to remove the hyphens in the example? |
Contributor
Author
|
Done! |
Collaborator
|
Also the 0.1 release is over 6 years old, so we should probably get a 0.2 out, so let us know when everything is working and we can cut a release (and create a BCR entry for that matter) |
ahumesky
approved these changes
Nov 11, 2024
Collaborator
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is official or documented anywhere, but it looks like the mapping file ID must be a UUID without hyphens. Uploading a file with a UUID like 6ac7912c-d163-47a0-ae4e-f6d3ad3a21c7 results in an API response like:
Removing the hyphens makes it work.
I'm not sure how "generalizable" we want the code in this repository to be. It seems to me that this target should specifically be used to generate a UUID that can be used directly for a mapping file upload. To that end, I think it is correct to follow the exact format that makes this work, rather than make something purely generalizable.