Add special -parse-as-library handling for swift_binary #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if we should do this or not. But folks having to know to pass |
|
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/258 (must be Lyft employee to view) |
brentleyjones
approved these changes
Mar 17, 2022
thii
reviewed
Mar 17, 2022
This matches the behavior implemented in swiftlang/swift-package-manager#3410 for single file modules.
keith
force-pushed
the
ks/add-special-parse-as-library-handling-for-swift_binary
branch
from
d1157c8 to
5776d5b
Compare
keith
deleted the
ks/add-special-parse-as-library-handling-for-swift_binary
branch
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
This matches the behavior implemented in swiftlang/swift-package-manager#3410 for single file modules. Fixes bazelbuild#913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the behavior implemented in swiftlang/swift-package-manager#3410 for single file modules.
Fixes #913