Add test for swift_binary transitive runfiles #1507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add coverage that makes sure that transitive runfiles from swift_libraries are pulled into swift_binary rules Signed-off-by: Maxwell Elliott <[email protected]>
maxwellE
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
Signed-off-by: Maxwell Elliott <[email protected]>
brentleyjones
approved these changes
Apr 11, 2025
brentleyjones
pushed a commit
that referenced
this pull request
Apr 11, 2025
Add coverage that makes sure that transitive runfiles from swift_libraries are pulled into swift_binary rules --------- Signed-off-by: Maxwell Elliott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage that makes sure that transitive runfiles from swift_libraries are pulled into swift_binary rules