Use correct env for rust_test #3764
Open
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expands the `rust_test` environment make variables directly instead of using the "build script" helper. The build script helper is incorrect here and this leads issues in Bazel 8.
nmattia
force-pushed
the
nm-rust-test-env
branch
from
b60486c to
b401d8f
Compare
nmattia
added a commit
to dfinity/ic
that referenced
this pull request
Dec 9, 2025
This introduces a rules_rust patch to work around issues in how the `rust_test` environment is set up. This issue leads to wasm_spec test failures in Bazel 8 where the test runner cannot find the spec files. See also: bazelbuild/rules_rust#3764
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Dec 9, 2025
This introduces a rules_rust patch to work around issues in how the `rust_test` environment is set up. This issue leads to wasm_spec test failures in Bazel 8 where the test runner cannot find the spec files. See also: bazelbuild/rules_rust#3764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the
rust_testenvironment make variables directly instead of using the "build script" helper. The build script helper is incorrect here and this leads issues in Bazel 8.Note: this was inspired by rules_shell.